Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754105AbaLVHee (ORCPT ); Mon, 22 Dec 2014 02:34:34 -0500 Received: from mail-oi0-f54.google.com ([209.85.218.54]:51333 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750928AbaLVHed (ORCPT ); Mon, 22 Dec 2014 02:34:33 -0500 MIME-Version: 1.0 In-Reply-To: <1419201796-13790-1-git-send-email-rickard_strandqvist@spectrumdigital.se> References: <1419201796-13790-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Date: Mon, 22 Dec 2014 07:34:32 +0000 Message-ID: Subject: Re: [PATCH] staging: line6: toneport.c: Fix for possible null pointer dereference From: Stefan Hajnoczi To: Rickard Strandqvist Cc: Greg Kroah-Hartman , Jerry Snitselaar , Fabian Mewes , devel@driverdev.osuosl.org, linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 21, 2014 at 10:43 PM, Rickard Strandqvist wrote: > The NULL check was done to late, and there it was a risk > of a possible null pointer dereference. > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/line6/toneport.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) Reviewed-by: Stefan Hajnoczi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/