Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754316AbaLVKEp (ORCPT ); Mon, 22 Dec 2014 05:04:45 -0500 Received: from mail-qc0-f169.google.com ([209.85.216.169]:39502 "EHLO mail-qc0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754241AbaLVKEn (ORCPT ); Mon, 22 Dec 2014 05:04:43 -0500 MIME-Version: 1.0 In-Reply-To: References: <1418412516-10682-1-git-send-email-bjorn.andersson@sonymobile.com> Date: Mon, 22 Dec 2014 11:04:42 +0100 Message-ID: Subject: Re: [PATCH] mmc: dt: Add property for broken hs200 quirk From: Ulf Hansson To: Bjorn Andersson Cc: Bjorn Andersson , Anton Vorontsov , Chris Ball , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Grant Likely , "open list:OPEN FIRMWARE AND..." , open list , "open list:SECURE DIGITAL HO..." Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19 December 2014 at 21:01, Bjorn Andersson wrote: > On Fri, Dec 19, 2014 at 3:38 AM, Ulf Hansson wrote: >> On 12 December 2014 at 20:28, Bjorn Andersson >> wrote: >> >> Some more explanation to why this needed would be good. >> > > Because (according to the git log) some of the memories that we > mounted in Xperia Z1 does not support HS200 even though they advertise > they are. I see. How about using an mmc card quirk instead of a DT binding then? Kind regards Uffe > > I thought we needed for the device I'm testing with, but a couple of > regulator_set_optimum_mode() solved that - so I have to provide a > patch for that as well... > >>> Signed-off-by: Bjorn Andersson >>> --- >>> Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++ >> >> This file lists the generic mmc DT bindings, but you want to add a >> specific binding for sdhci? >> > > Looking in sdhci_get_of_property() it's a mash of device specific > properties, sdhci specific properties documented in mmc.txt and > generic sdhci properties documented in device specific bindings. > > Would you like me to move it to a generic sdhci.txt binding and update > the individual sdhci-* to reference that instead of mmc.txt? Or should > I just add the property in the device specific bindings? Or maybe we > could keep it as a optional property in mmc.txt? > > Regards, > Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/