Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754942AbaLVOJY (ORCPT ); Mon, 22 Dec 2014 09:09:24 -0500 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:47066 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754524AbaLVOJX (ORCPT ); Mon, 22 Dec 2014 09:09:23 -0500 Message-ID: <549825EC.80505@arm.com> Date: Mon, 22 Dec 2014 14:08:44 +0000 From: Andrew Jackson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Mark Brown CC: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Rajeev Kumar , Liviu Dudau , Lars-Peter Clausen , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 2/5] ASoC: dwc: Iterate over all channels References: <67cea1f0a74c333ec2048c7796cda37302d45e95.1418826016.git.Andrew.Jackson@arm.com> <20141222135301.GQ17800@sirena.org.uk> In-Reply-To: <20141222135301.GQ17800@sirena.org.uk> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/22/14 13:53, Mark Brown wrote: > On Fri, Dec 19, 2014 at 04:18:06PM +0000, Andrew Jackson wrote: > >> The Designware core can be configured with up to four stereo channels. >> Each stereo channel is individually configured so, when the driver's >> hw_params call is made, each requested stereo channel has to be >> programmed. > > This is quite unclear to someone who doesn't know the hardware, is this > a bug fix or a new feature? It looks like it's a fix... > It is a fix. In the Designware core, each stereo channel is configured individually. So, when hw_params is called to configure N channels, N/2 stereo channels need to be configured in the core. The existing code doesn't do this and will only configure the highest numbered channel. Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/