Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754953AbaLVTAn (ORCPT ); Mon, 22 Dec 2014 14:00:43 -0500 Received: from mga01.intel.com ([192.55.52.88]:60364 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754378AbaLVTAm (ORCPT ); Mon, 22 Dec 2014 14:00:42 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="432256260" Date: Mon, 22 Dec 2014 11:00:41 -0800 From: Andi Kleen To: Alex Deucher Cc: rusty@rustcorp.com.au, Dana Elifaz , LKML , Maling list - DRI developers , Oded Gabbay , Alexander Deucher , LKP ML Subject: Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel Message-ID: <20141222190041.GC17192@tassilo.jf.intel.com> References: <1419246673-7222-1-git-send-email-oded.gabbay@amd.com> <20141222184940.GB17192@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141222184940.GB17192@tassilo.jf.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 22, 2014 at 10:49:40AM -0800, Andi Kleen wrote: > On Mon, Dec 22, 2014 at 11:58:43AM -0500, Alex Deucher wrote: > > On Mon, Dec 22, 2014 at 6:11 AM, Oded Gabbay wrote: > > > amdkfd driver can be compiled only in 64-bit kernel. Therefore, there is no > > > point in trying to initialize amdkfd in 32-bit kernel. > > > > > > In addition, in case of specific configuration of 32-bit kernel, no modules and > > > random kernel base, the symbol_request function doesn't work as expected - It > > > doesn't return NULL if the symbol doesn't exists. That makes the kernel panic. > > > Therefore, the as amdkfd doesn't compile in 32-bit kernel, the best way is just > > > to return false immediately. > > > > > > Signed-off-by: Oded Gabbay > > > > Reviewed-by: Alex Deucher > > Sorry but the patch is just bogus. X-bit only code is usually > a very bad sign for the code. This is not windows programing after all. > > Even if you wanted to do a 64bit only driver -- which > you probably don't -- the standard way would be to exclude > it in Kconfig. > > Please root-cause why symbol_request doesn't work on 32bit > and fix it properly. > > +rusty. And also with correct email. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/