Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756108AbaLWKvb (ORCPT ); Tue, 23 Dec 2014 05:51:31 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:44944 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754411AbaLWKv3 (ORCPT ); Tue, 23 Dec 2014 05:51:29 -0500 Date: Tue, 23 Dec 2014 02:51:28 -0800 From: Christoph Hellwig To: Dongsu Park Cc: linux-kernel@vger.kernel.org, Jens Axboe , Kent Overstreet , Ming Lin , Al Viro , linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [RFC PATCH 16/17] fs: convert buffer head etc. to use immutable biovecs API. Message-ID: <20141223105128.GE27600@infradead.org> References: <4287748e7d1a0fce1c951567a7688821f1a21e5e.1419241597.git.dongsu.park@profitbricks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4287748e7d1a0fce1c951567a7688821f1a21e5e.1419241597.git.dongsu.park@profitbricks.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 22, 2014 at 12:48:43PM +0100, Dongsu Park wrote: > From: Kent Overstreet > > Increase bio->bi_remaining instead of calling bio_get(), > and call bio_end() instead of bio_put() upon buffer_head submission. Nees an explanation on why this is done. > Also make bio submission in kernel/power/block_io.c to properly submit > bios by checking whether bio_chain is available or not. Should be a separate patch. And of course both should go into the preparation series of cleanups. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/