Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756272AbaLWPhz (ORCPT ); Tue, 23 Dec 2014 10:37:55 -0500 Received: from mail-qg0-f50.google.com ([209.85.192.50]:47632 "EHLO mail-qg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756234AbaLWPhx (ORCPT ); Tue, 23 Dec 2014 10:37:53 -0500 MIME-Version: 1.0 In-Reply-To: <1419286616-9893-2-git-send-email-wsa@the-dreams.de> References: <1419286616-9893-1-git-send-email-wsa@the-dreams.de> <1419286616-9893-2-git-send-email-wsa@the-dreams.de> Date: Tue, 23 Dec 2014 16:37:52 +0100 Message-ID: Subject: Re: [PATCH 2/3] mmc: host: don't use devm_pinctrl_get_select_default() in probe From: Ulf Hansson To: Wolfram Sang Cc: "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Nicolas Pitre , Chris Ball , linux-mmc Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22 December 2014 at 23:16, Wolfram Sang wrote: > Since commit ab78029ecc34 (drivers/pinctrl: grab default handles from device > core), we can rely on device core for setting the default pins. > > Signed-off-by: Wolfram Sang Thanks! Applied for next, with an updated prefix of the commit header to "mmc: mvsdio:". Kind regards Uffe > --- > drivers/mmc/host/mvsdio.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c > index 4f8618f4522d..a2cb92851f1f 100644 > --- a/drivers/mmc/host/mvsdio.c > +++ b/drivers/mmc/host/mvsdio.c > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > > #include > #include > @@ -704,7 +703,6 @@ static int mvsd_probe(struct platform_device *pdev) > const struct mbus_dram_target_info *dram; > struct resource *r; > int ret, irq; > - struct pinctrl *pinctrl; > > r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > irq = platform_get_irq(pdev, 0); > @@ -721,10 +719,6 @@ static int mvsd_probe(struct platform_device *pdev) > host->mmc = mmc; > host->dev = &pdev->dev; > > - pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > - if (IS_ERR(pinctrl)) > - dev_warn(&pdev->dev, "no pins associated\n"); > - > /* > * Some non-DT platforms do not pass a clock, and the clock > * frequency is passed through platform_data. On DT platforms, > -- > 2.1.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/