Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752028AbaLXNQG (ORCPT ); Wed, 24 Dec 2014 08:16:06 -0500 Received: from mail-pd0-f173.google.com ([209.85.192.173]:64285 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751623AbaLXNQE (ORCPT ); Wed, 24 Dec 2014 08:16:04 -0500 Date: Wed, 24 Dec 2014 18:45:57 +0530 From: Vaishali Thakkar To: linux-wireless@vger.kernel.org Cc: lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org, sameo@linux.intel.com, linux-kernel@vger.kernel.org, johannes.berg@intel.com, arend@broadcom.com Subject: [PATCH v3] NFC: port100: Introduce the use of function put_unaligned_le16 Message-ID: <20141224131557.GA2591@vaishali-Ideapad-Z570> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch introduces the use of function put_unaligned_le16. This is done using Coccinelle and semantic patch used is as follows: @a@ typedef u16, __le16; {u16,__le16} e16; identifier tmp; expression ptr; expression y,e; type T; @@ - tmp = cpu_to_le16(y); <+... when != tmp ( - memcpy(ptr, (T)&tmp, \(2\|sizeof(u16)\|sizeof(__le16)\|sizeof(e16)\)); + put_unaligned_le16(y,ptr); | - memcpy(ptr, (T)&tmp, ...); + put_unaligned_le16(y,ptr); ) ...+> ? tmp = e @@ type T; identifier a.tmp; @@ - T tmp; ...when != tmp Signed-off-by: Vaishali Thakkar --- Changes since v1: has arch-specific knowlege of which of the implementations needs to be used. So, include it instaed of . Changes since v2: Fix typing mistake in subject drivers/nfc/port100.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/nfc/port100.c b/drivers/nfc/port100.c index 4ac4d31..440f0f3 100644 --- a/drivers/nfc/port100.c +++ b/drivers/nfc/port100.c @@ -18,6 +18,7 @@ #include #include #include +#include #define VERSION "0.1" @@ -1136,7 +1137,6 @@ static int port100_in_send_cmd(struct nfc_digital_dev *ddev, { struct port100 *dev = nfc_digital_get_drvdata(ddev); struct port100_cb_arg *cb_arg; - __le16 timeout; cb_arg = kzalloc(sizeof(struct port100_cb_arg), GFP_KERNEL); if (!cb_arg) @@ -1145,9 +1145,7 @@ static int port100_in_send_cmd(struct nfc_digital_dev *ddev, cb_arg->complete_cb = cb; cb_arg->complete_arg = arg; - timeout = cpu_to_le16(_timeout * 10); - - memcpy(skb_push(skb, sizeof(__le16)), &timeout, sizeof(__le16)); + put_unaligned_le16(_timeout * 10, skb_push(skb, sizeof(__le16))); return port100_send_cmd_async(dev, PORT100_CMD_IN_COMM_RF, skb, port100_in_comm_rf_complete, cb_arg); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/