Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752486AbaLYKPk (ORCPT ); Thu, 25 Dec 2014 05:15:40 -0500 Received: from cantor2.suse.de ([195.135.220.15]:60460 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752133AbaLYKPj (ORCPT ); Thu, 25 Dec 2014 05:15:39 -0500 Date: Thu, 25 Dec 2014 11:15:38 +0100 Message-ID: From: Takashi Iwai To: Rickard Strandqvist Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: isa: gus: gus_instr.c: Remove unused function In-Reply-To: <1419095004-9727-1-git-send-email-rickard_strandqvist@spectrumdigital.se> References: <1419095004-9727-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sat, 20 Dec 2014 18:03:24 +0100, Rickard Strandqvist wrote: > > Remove the function snd_gus_simple_remove_sample() that is not used anywhere. > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist The whole instrument manager function was dropped many years ago, but this file and functions are left for the future (re-)implementation. But judging from the current situation, the chance that we'll get a new feature for GUS boards is quite low, so rather we should simply delete this file. The developer can still refer to the git repository as a reference. Will do that for for-next branch. thanks, Takashi > --- > sound/isa/gus/gus_instr.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/sound/isa/gus/gus_instr.c b/sound/isa/gus/gus_instr.c > index 4dc9caf..2d21408 100644 > --- a/sound/isa/gus/gus_instr.c > +++ b/sound/isa/gus/gus_instr.c > @@ -162,11 +162,3 @@ int snd_gus_simple_get_sample(void *private_data, struct simple_instrument *inst > > return snd_gus_dram_read(gus, data, instr->address.memory, instr->size, 0); > } > - > -int snd_gus_simple_remove_sample(void *private_data, struct simple_instrument *instr, > - int atomic) > -{ > - struct snd_gus_card *gus = private_data; > - > - return snd_gf1_mem_free(&gus->gf1.mem_alloc, instr->address.memory); > -} > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/