Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751989AbaLZOfi (ORCPT ); Fri, 26 Dec 2014 09:35:38 -0500 Received: from mail-pa0-f50.google.com ([209.85.220.50]:59326 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496AbaLZOfg (ORCPT ); Fri, 26 Dec 2014 09:35:36 -0500 Date: Fri, 26 Dec 2014 06:35:32 -0800 From: Jeremiah Mahler To: Alexander Kuleshov Cc: "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: Remove excess calculations for heap_end_ptr Message-ID: <20141226143532.GB28213@newt.localdomain> Mail-Followup-To: Jeremiah Mahler , Alexander Kuleshov , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org References: <1419596562-20679-1-git-send-email-kuleshovmail@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1419596562-20679-1-git-send-email-kuleshovmail@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alexander, On Fri, Dec 26, 2014 at 06:22:42PM +0600, Alexander Kuleshov wrote: > heap_end_ptr default value defined as _end+STACK_SZE-512, but STACK_SIZE > STACK_SIZE is already 512. > > Signed-off-by: Alexander Kuleshov > --- > arch/x86/boot/header.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S > index 16ef025..c69b870 100644 > --- a/arch/x86/boot/header.S > +++ b/arch/x86/boot/header.S > @@ -342,7 +342,7 @@ ramdisk_size: .long 0 # its size in bytes > bootsect_kludge: > .long 0 # obsolete > > -heap_end_ptr: .word _end+STACK_SIZE-512 > +heap_end_ptr: .word _end > # (Header version 0x0201 or later) > # space from here (exclusive) down to > # end of setup code can be used by setup So right now STACK_SIZE happens to be 512 so STACK_SIZE-512 is zero. What happens if someone changes the size of STACK_SIZE? This change doesn't fix any problem right now and creates potential problems in the future. > -- > 2.2.1.201.gbbcefff > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/