Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751487AbaLZRDj (ORCPT ); Fri, 26 Dec 2014 12:03:39 -0500 Received: from mail-ob0-f172.google.com ([209.85.214.172]:46573 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751347AbaLZRDi (ORCPT ); Fri, 26 Dec 2014 12:03:38 -0500 MIME-Version: 1.0 In-Reply-To: <20141226143532.GB28213@newt.localdomain> References: <1419596562-20679-1-git-send-email-kuleshovmail@gmail.com> <20141226143532.GB28213@newt.localdomain> Date: Fri, 26 Dec 2014 23:03:38 +0600 Message-ID: Subject: Re: [PATCH] x86: Remove excess calculations for heap_end_ptr From: Alexander Kuleshov To: Jeremiah Mahler , Alexander Kuleshov , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yes, you're right, At first i thought that it is just typo, and right after that i thought about this case when somebody will change STACK_SIZE 2014-12-26 20:35 GMT+06:00 Jeremiah Mahler : > Alexander, > > On Fri, Dec 26, 2014 at 06:22:42PM +0600, Alexander Kuleshov wrote: >> heap_end_ptr default value defined as _end+STACK_SZE-512, but > STACK_SIZE > >> STACK_SIZE is already 512. >> >> Signed-off-by: Alexander Kuleshov >> --- >> arch/x86/boot/header.S | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S >> index 16ef025..c69b870 100644 >> --- a/arch/x86/boot/header.S >> +++ b/arch/x86/boot/header.S >> @@ -342,7 +342,7 @@ ramdisk_size: .long 0 # its size in bytes >> bootsect_kludge: >> .long 0 # obsolete >> >> -heap_end_ptr: .word _end+STACK_SIZE-512 >> +heap_end_ptr: .word _end >> # (Header version 0x0201 or later) >> # space from here (exclusive) down to >> # end of setup code can be used by setup > > So right now STACK_SIZE happens to be 512 so STACK_SIZE-512 is zero. > What happens if someone changes the size of STACK_SIZE? > > This change doesn't fix any problem right now and creates potential > problems in the future. > >> -- >> 2.2.1.201.gbbcefff >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > > -- > - Jeremiah Mahler -- _________________________ 0xAX -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/