Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751573AbaLZX6z (ORCPT ); Fri, 26 Dec 2014 18:58:55 -0500 Received: from na3sys009aog129.obsmtp.com ([74.125.149.142]:47591 "HELO na3sys009aog129.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750779AbaLZX6x (ORCPT ); Fri, 26 Dec 2014 18:58:53 -0500 MIME-Version: 1.0 In-Reply-To: <1417806738.2404.42.camel@jtkirshe-mobl> References: <1417804872-58635-1-git-send-email-joestringer@nicira.com> <1417806738.2404.42.camel@jtkirshe-mobl> From: Jesse Gross Date: Fri, 26 Dec 2014 18:58:32 -0500 Message-ID: Subject: Re: [linux-nics] [PATCHv4 net] i40e: Implement ndo_gso_check() To: Jeff Kirsher Cc: Joe Stringer , netdev , "linux.nics" , Linux Kernel Mailing List , Tom Herbert Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 5, 2014 at 2:12 PM, Jeff Kirsher wrote: > On Fri, 2014-12-05 at 10:41 -0800, Joe Stringer wrote: >> ndo_gso_check() was recently introduced to allow NICs to report the >> offloading support that they have on a per-skb basis. Add an >> implementation for this driver which checks for IPIP, GRE, UDP >> tunnels. >> >> Signed-off-by: Joe Stringer >> --- >> v4: Simplify the check to just do tunnel header length. >> Fix #define style issue. >> v3: Drop IPIP and GRE (no driver support even though hw supports it). >> Check for UDP outer protocol for UDP tunnels. >> v2: Expand to include IP in IP and IPv4/IPv6 inside GRE/UDP tunnels. >> Add MAX_INNER_LENGTH (as 80). >> --- >> drivers/net/ethernet/intel/i40e/i40e_main.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) > > Thanks Joe, I will update the patch in my queue with your latest > version. Jeff, as a heads-up, this patch and the corresponding one for fm10k will no longer apply now that the ndo has changed. This was changed by 5f35227e ("net: Generalize ndo_gso_check to ndo_features_check"). The update needed is trivial and is just due to the change in the function signature but I'm not sure where you are in the testing process with this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/