Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751595AbaL0BdX (ORCPT ); Fri, 26 Dec 2014 20:33:23 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:23070 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808AbaL0BdT (ORCPT ); Fri, 26 Dec 2014 20:33:19 -0500 Message-ID: <549E0C4D.6010904@huawei.com> Date: Sat, 27 Dec 2014 09:33:01 +0800 From: Wang Weidong User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: "Rafael J. Wysocki" , Viresh Kumar CC: "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , wangweidong Subject: [PATCH RESEND v2] acpi-cpufreq: make the freq_table store the same freq value References: <547AEEB4.2020803@huawei.com> In-Reply-To: <547AEEB4.2020803@huawei.com> X-Forwarded-Message-Id: <547AEEB4.2020803@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.18.75] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.549E0C5B.0091,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 2f8f21fa4b9e868f6ea3d862ef8ad2f7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ACPI's P-states will report the acpi_processor_px *states to acpi-cpufreq. When the states likes these: [index:freq, 0:2400 1:2400 2:2000 3:1600...], we will initialize the freq_tables to those: [index:driver_data:freq, 0:0:2400, 1:2:2000 2:3,1600 ... CPUFREQ_TABLE_END] So when set the freqs to 2000, the data->acpi_data->state is 2 (data->freq_table[1].driver_data), So when call get_cur_freq_on_cpu, we get the freqs is data->freq_table[2].frequency,the value is 1600. we can make the freq_table store the same value to fix this case problem. Signed-off-by: Wang Weidong --- Change note: v2: to check weather the freq_table will be changeable and clarify the problem. The set of available states which come from acpi won't change. Just like the power would be remove, the acpi driver will do that: ->acpi_processor_ppc_has_changed ->cpufreq_update_policy ->acpi_ppc_notifier_block.notifier_call ->acpi_processor_ppc_notifier ->cpufreq_verify_within_limits The progress will change the policy's min_freq and max_freq while it won't change the set of states(freq_tables). --- drivers/cpufreq/acpi-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c index b0c18ed..93634a4 100644 --- a/drivers/cpufreq/acpi-cpufreq.c +++ b/drivers/cpufreq/acpi-cpufreq.c @@ -779,7 +779,7 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy) /* table init */ for (i = 0; i < perf->state_count; i++) { - if (i > 0 && perf->states[i].core_frequency >= + if (i > 0 && perf->states[i].core_frequency > data->freq_table[valid_states-1].frequency / 1000) continue; -- 1.7.12 . -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/