Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751425AbaL0IFm (ORCPT ); Sat, 27 Dec 2014 03:05:42 -0500 Received: from mail-wi0-f172.google.com ([209.85.212.172]:41311 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750826AbaL0IFl (ORCPT ); Sat, 27 Dec 2014 03:05:41 -0500 MIME-Version: 1.0 In-Reply-To: <20141226230748.GA57100@athens> References: <201412270742.z0dX9rhu%fengguang.wu@intel.com> <20141226230748.GA57100@athens> Date: Sat, 27 Dec 2014 10:05:39 +0200 X-Google-Sender-Auth: Hmi2HlInuUm-ynBO26GEEqsHSjk Message-ID: Subject: Re: [PATCH] iio: imu: kmx61: fix simple_return.cocci warnings From: Daniel Baluta To: kbuild test robot Cc: Daniel Baluta , kbuild-all@01.org, Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , "linux-iio@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 27, 2014 at 1:07 AM, kbuild test robot wrote: > drivers/iio/imu/kmx61.c:543:1-4: WARNING: end returns can be simpified > drivers/iio/imu/kmx61.c:480:1-4: WARNING: end returns can be simpified if negative or 0 value > > Simplify a trivial if-return sequence. Possibly combine with a > preceding function call. > Generated by: scripts/coccinelle/misc/simple_return.cocci > > CC: Daniel Baluta > Signed-off-by: Fengguang Wu > --- > > kmx61.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > --- a/drivers/iio/imu/kmx61.c > +++ b/drivers/iio/imu/kmx61.c > @@ -540,11 +540,7 @@ static int kmx61_setup_new_data_interrup > return ret; > } > > - ret = kmx61_set_mode(data, mode, KMX61_ACC | KMX61_MAG, true); > - if (ret) > - return ret; > - > - return 0; > + return kmx61_set_mode(data, mode, KMX61_ACC | KMX61_MAG, true); > } > > /** Fixed with this patch: http://marc.info/?l=linux-iio&m=141934100614777&w=2 Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/