Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751460AbaL0PCO (ORCPT ); Sat, 27 Dec 2014 10:02:14 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:41213 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751371AbaL0PCL (ORCPT ); Sat, 27 Dec 2014 10:02:11 -0500 Date: Sat, 27 Dec 2014 07:02:07 -0800 From: Christoph Hellwig To: Dongsu Park Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, Jens Axboe , Kent Overstreet , Ming Lin , Al Viro , Ming Lei , Neil Brown , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Jiri Kosina , Geoff Levand , Jim Paris , Joshua Morris , Philip Kelleher , Minchan Kim , Nitin Gupta , Oleg Drokin , Andreas Dilger Subject: Re: [RFC PATCH 01/17] block: make generic_make_request handle arbitrarily sized bios Message-ID: <20141227150207.GC1094@infradead.org> References: <20141223101614.GA13138@infradead.org> <20141223114140.GB15080@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141223114140.GB15080@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 23, 2014 at 12:41:40PM +0100, Dongsu Park wrote: > You mean, checking rq->cmd_type == REQ_TYPE_BLOCK_PC, right? > > I'm wondering about how to check that in blk_queue_split(). > At the moment when blk_queue_split() is called, it's even before a request > is mapped e.g. in blk_sq_make_request(). > Unlike scsi drivers where it's easy to get cmd->rq, blk_queue_split() > doesn't seem to be able to get a request by blk_get_request(). > > Or am I missing something? You're probably missing what I didn't notice either: BLOCK_PC requests are never sent through ->make_request. Consider my comment withdrawn and sorry for the confusion. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/