Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751897AbaL1Vxn (ORCPT ); Sun, 28 Dec 2014 16:53:43 -0500 Received: from mail-wg0-f46.google.com ([74.125.82.46]:49780 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751453AbaL1Vxl (ORCPT ); Sun, 28 Dec 2014 16:53:41 -0500 Date: Sun, 28 Dec 2014 22:54:05 +0100 From: Olivier Sobrie To: "Ahmed S. Darwish" Cc: Oliver Hartkopp , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Paul Gortmaker , Greg KH , Linux-CAN , netdev , LKML Subject: Re: [PATCH v2 3/4] can: kvaser_usb: Don't send a RESET_CHIP for non-existing channels Message-ID: <20141228215405.GC2548@thinkoso.home> Reply-To: Olivier Sobrie References: <20141223154654.GB6460@vivalin-002> <20141224235644.GA3778@vivalin-002> <20141224235954.GA24302@vivalin-002> <20141225000256.GB24302@vivalin-002> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141225000256.GB24302@vivalin-002> X-PGP-Key: http://olivier.sobrie.be/pgp/public.key User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 25, 2014 at 02:02:56AM +0200, Ahmed S. Darwish wrote: > From: Ahmed S. Darwish > > "Someone reported me that recent leaf firmwares go in trouble when > you send a command for a channel that does not exist. Instead ... > you can move the reset command to kvaser_usb_init_one() function." Please adapt the commit log message as follows: Recent Leaf firmware versions (>= 3.1.557) do not allow to send commands for non-existing channels. If a command is send for a non-existing channel, the firmware crashes. And you can add: Reported-by: Christopher Storah Signed-off-by: Olivier Sobrie Kr, Olivier > > Suggested-by: Olivier Sobrie > Signed-off-by: Ahmed S. Darwish > --- > drivers/net/can/usb/kvaser_usb.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/can/usb/kvaser_usb.c b/drivers/net/can/usb/kvaser_usb.c > index 598e251..2791501 100644 > --- a/drivers/net/can/usb/kvaser_usb.c > +++ b/drivers/net/can/usb/kvaser_usb.c > @@ -1505,6 +1505,10 @@ static int kvaser_usb_init_one(struct usb_interface *intf, > struct kvaser_usb_net_priv *priv; > int i, err; > > + err = kvaser_usb_send_simple_msg(dev, CMD_RESET_CHIP, channel); > + if (err) > + return err; > + > netdev = alloc_candev(sizeof(*priv), MAX_TX_URBS); > if (!netdev) { > dev_err(&intf->dev, "Cannot alloc candev\n"); > @@ -1609,9 +1613,6 @@ static int kvaser_usb_probe(struct usb_interface *intf, > > usb_set_intfdata(intf, dev); > > - for (i = 0; i < MAX_NET_DEVICES; i++) > - kvaser_usb_send_simple_msg(dev, CMD_RESET_CHIP, i); > - > err = kvaser_usb_get_software_info(dev); > if (err) { > dev_err(&intf->dev, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/