Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751967AbaL2Ckw (ORCPT ); Sun, 28 Dec 2014 21:40:52 -0500 Received: from mail-oi0-f54.google.com ([209.85.218.54]:37139 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751852AbaL2Cks (ORCPT ); Sun, 28 Dec 2014 21:40:48 -0500 From: hejianet X-Google-Original-From: hejianet Message-ID: <54A0BF9D.7090709@gmail.com> Date: Mon, 29 Dec 2014 10:42:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: linux-kernel@vger.kernel.org CC: Oleg Drokin , Andreas Dilger , Greg Kroah-Hartman Subject: Re: [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration References: <1418740778-827-1-git-send-email-hejianet@gmail.com> In-Reply-To: <1418740778-827-1-git-send-email-hejianet@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Thanks for any comments On Tue, 16 Dec 2014 22:39:38 +0800 from hejianet@gmail.com wrote: > make sparse happy since these two fuchtion are only used in module.c. > tested by successful compilation. > > Signed-off-by: Jia He > Cc: Oleg Drokin > Cc: Andreas Dilger > Cc: Greg Kroah-Hartman > --- > drivers/staging/lustre/lustre/libcfs/module.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/libcfs/module.c b/drivers/staging/lustre/lustre/libcfs/module.c > index 2c4fc74..b9ee37c 100644 > --- a/drivers/staging/lustre/lustre/libcfs/module.c > +++ b/drivers/staging/lustre/lustre/libcfs/module.c > @@ -42,8 +42,7 @@ > #include "../../include/linux/lnet/lnet.h" > #include "tracefile.h" > > -void > -kportal_memhog_free (struct libcfs_device_userstate *ldu) > +static void kportal_memhog_free (struct libcfs_device_userstate *ldu) > { > struct page **level0p = &ldu->ldu_memhog_root_page; > struct page **level1p; > @@ -86,8 +85,7 @@ kportal_memhog_free (struct libcfs_device_userstate *ldu) > LASSERT (ldu->ldu_memhog_pages == 0); > } > > -int > -kportal_memhog_alloc(struct libcfs_device_userstate *ldu, int npages, > +static int kportal_memhog_alloc(struct libcfs_device_userstate *ldu, int npages, > gfp_t flags) > { > struct page **level0p; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/