Message-ID: <1419822060.18886.1.camel@perches.com>
Subject: Re: [PATCH] fs: overlayfs: Fix coding style issues, missing a blank
 line after declarations
From: Joe Perches <joe@perches.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Date: Sun, 28 Dec 2014 19:01:00 -0800
In-Reply-To: <20141229024951.GA9934@ZenIV.linux.org.uk>
References: <1419746213-5405-1-git-send-email-kuleshovmail@gmail.com>
	 <20141229023939.GL22149@ZenIV.linux.org.uk>
	 <20141229024951.GA9934@ZenIV.linux.org.uk>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Mon, 2014-12-29 at 02:49 +0000, Al Viro wrote:
> On Mon, Dec 29, 2014 at 02:39:39AM +0000, Al Viro wrote:
> > On Sun, Dec 28, 2014 at 11:56:53AM +0600, Alexander Kuleshov wrote:
> > > Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> > > ---
> > 
> > For the record: anything of that sort against fs/*.c will be flushed down
> > the toilet where such valuable contributions belong.  Don't even bother.
> 
> Joe, could you please explain what has driven you to include that into
> scripts/checkpatch.pl and open the countless sphincters?  Aren't we
> getting enough pointless patches as it is?

I don't care for that style actually.
It was Andrew Morton that wanted it used globally.

I wanted it to be a --strict test and only for
net/ and drivers/net/ where David Miller prefers
that style.

https://lkml.org/lkml/2014/3/6/550

> Al, stongly tempted to try and sneak a patch to checkpatch.pl declaring the
> lack of /* See Figure 1 */ within the first 10 lines of a function an offense
> against the Gods Of Style.  Then sit back and watch the resulting spew...

Cool.  Awaiting your patch...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/