Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752026AbaL2JCI (ORCPT ); Mon, 29 Dec 2014 04:02:08 -0500 Received: from ozlabs.org ([103.22.144.67]:43869 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751480AbaL2JCF (ORCPT ); Mon, 29 Dec 2014 04:02:05 -0500 Message-ID: <1419843707.30395.5.camel@ellerman.id.au> Subject: Re: [PATCH] powerpc/powernv: Select CONFIG_PRINTK to fix build failure From: Michael Ellerman To: Pranith Kumar Cc: Benjamin Herrenschmidt , Paul Mackerras , "Srivatsa S. Bhat" , "Rafael J. Wysocki" , "Gautham R. Shenoy" , Michael Neuling , "open list:LINUX FOR POWERPC..." , open list , hegdevasant@linux.vnet.ibm.com In-Reply-To: <1419700667-24888-2-git-send-email-bobby.prani@gmail.com> References: <1419700667-24888-1-git-send-email-bobby.prani@gmail.com> <1419700667-24888-2-git-send-email-bobby.prani@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 29 Dec 2014 20:01:47 +1100 Mime-Version: 1.0 X-Mailer: Evolution 3.12.7-0ubuntu1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2014-12-27 at 12:17 -0500, Pranith Kumar wrote: > In an allnoconfig we get the following build failure: An allnoconfig doesn't include CONFIG_PPC_POWERNV? But I think I know what you mean. > arch/powerpc/platforms/built-in.o: In function `.__machine_initcall_powernv_opal_init': > opal.c:(.init.text+0x468): undefined reference to `.log_buf_addr_get' > opal.c:(.init.text+0x474): undefined reference to `.log_buf_len_get' > make: *** [vmlinux] Error 1 > > This happens because powernv requires printk() support. Enable it in the config > file. Sort of. It just requires those two routines. Or is there a stronger dependency? I think the better fix is for those two routines to be defined for CONFIG_PRINTK=n, but return NULL and zero respectively. And the opal code could skip registering the region when they return NULL/zero. Care to do a couple of patches? cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/