Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752166AbaL3MFQ (ORCPT ); Tue, 30 Dec 2014 07:05:16 -0500 Received: from [198.137.202.9] ([198.137.202.9]:37154 "EHLO bombadil.infradead.org" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751683AbaL3MFO (ORCPT ); Tue, 30 Dec 2014 07:05:14 -0500 Date: Tue, 30 Dec 2014 04:04:49 -0800 From: Christoph Hellwig To: Ben Hutchings Cc: Eric B Munson , JBottomley@parallels.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] Initialize off value in asd_process_ctrl_a_user() Message-ID: <20141230120449.GA32187@infradead.org> References: <1417538041-6850-1-git-send-email-emunson@akamai.com> <1419779536.4705.183.camel@decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1419779536.4705.183.camel@decadent.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 28, 2014 at 04:12:16PM +0100, Ben Hutchings wrote: > On Tue, 2014-12-02 at 11:34 -0500, Eric B Munson wrote: > > If the asd_find_flash_de() function returns ENOENT the off value will > > be used uninitialized in the call to asd_read_flash_seg(). > > This is just papering over the problem. This was my attempt at a proper > fix: http://article.gmane.org/gmane.linux.scsi/91320 That one looks much more useful to me. Can someone give it a second review? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/