Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752118AbaL3Wwl (ORCPT ); Tue, 30 Dec 2014 17:52:41 -0500 Received: from smtp89.iad3a.emailsrvr.com ([173.203.187.89]:49032 "EHLO smtp89.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751952AbaL3Wwj (ORCPT ); Tue, 30 Dec 2014 17:52:39 -0500 X-Sender-Id: abbotti@mev.co.uk Message-ID: <54A32CAB.7090905@mev.co.uk> Date: Tue, 30 Dec 2014 22:52:27 +0000 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Andreas Siegling , devel@linuxdriverproject.org CC: linux-kernel@i4.cs.fau.de, hsweeten@visionengravers.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, ebru.akagunduz@gmail.com, chase.southwood@gmail.com, rickard_strandqvist@spectrumdigital.se, Zhutao Lu Subject: Re: [PATCH 3/3] comedi: checkpatch warning: missing blank line References: <1419792975-31519-1-git-send-email-andreas.siegling@fau.de> <1419792975-31519-4-git-send-email-andreas.siegling@fau.de> In-Reply-To: <1419792975-31519-4-git-send-email-andreas.siegling@fau.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/12/14 18:56, Andreas Siegling wrote: > This patch will fix all occurrences of the checkpatch warning: > WARNING: Missing a blank line after declarations > in drivers/staging/comedi/. > > Signed-off-by: Andreas Siegling > Signed-off-by: Zhutao Lu > --- > drivers/staging/comedi/drivers/comedi_bond.c | 1 + > drivers/staging/comedi/drivers/ni_stc.h | 4 ++++ > 2 files changed, 5 insertions(+) > > diff --git a/drivers/staging/comedi/drivers/comedi_bond.c b/drivers/staging/comedi/drivers/comedi_bond.c > index 85b2f4a..221d381 100644 > --- a/drivers/staging/comedi/drivers/comedi_bond.c > +++ b/drivers/staging/comedi/drivers/comedi_bond.c > @@ -261,6 +261,7 @@ static int do_dev_config(struct comedi_device *dev, struct comedi_devconfig *it) > { > /* Append dev:subdev to devpriv->name */ > char buf[20]; > + > snprintf(buf, sizeof(buf), "%u:%u ", > bdev->minor, bdev->subdev); > strlcat(devpriv->name, buf, > diff --git a/drivers/staging/comedi/drivers/ni_stc.h b/drivers/staging/comedi/drivers/ni_stc.h > index bb76fe1..3b8b3c5 100644 > --- a/drivers/staging/comedi/drivers/ni_stc.h > +++ b/drivers/staging/comedi/drivers/ni_stc.h > @@ -326,6 +326,7 @@ static inline unsigned RTSI_Output_Bit(unsigned channel, int is_mseries) > { > unsigned max_channel; > unsigned base_bit_shift; > + > if (is_mseries) { > base_bit_shift = 8; > max_channel = 7; > @@ -1142,6 +1143,7 @@ static inline unsigned MSeries_AI_Config_Bank_Bits(enum ni_reg_type reg_type, > unsigned channel) > { > unsigned bits = channel & 0x30; > + > if (reg_type == ni_reg_622x) { > if (channel & 0x40) > bits |= 0x400; > @@ -1191,6 +1193,7 @@ enum MSeries_PLL_Control_Bits { > static inline unsigned MSeries_PLL_Divisor_Bits(unsigned divisor) > { > static const unsigned max_divisor = 0x10; > + > if (divisor < 1 || divisor > max_divisor) { > pr_err("%s: bug, invalid divisor=%i\n", __func__, divisor); > return 0; > @@ -1201,6 +1204,7 @@ static inline unsigned MSeries_PLL_Divisor_Bits(unsigned divisor) > static inline unsigned MSeries_PLL_Multiplier_Bits(unsigned multiplier) > { > static const unsigned max_multiplier = 0x100; > + > if (multiplier < 1 || multiplier > max_multiplier) { > pr_err("%s: bug, invalid multiplier=%i\n", __func__, > multiplier); > Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/