Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751453AbaLaQVX (ORCPT ); Wed, 31 Dec 2014 11:21:23 -0500 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:36061 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750726AbaLaQVV (ORCPT ); Wed, 31 Dec 2014 11:21:21 -0500 From: Andrew Jackson To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: Lars-Peter Clausen , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andrew Jackson Subject: [PATCH] ASoC: adi: Add missing return statement. Date: Wed, 31 Dec 2014 16:20:37 +0000 Message-Id: <1420042837-3337-1-git-send-email-andrew.jackson@arm.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrew Jackson The probe routine was disabling the clock even if the system was configured successfully. Add a return statement to leave clocks enabled. Signed-off-by: Andrew Jackson --- Spotted while reviewing clock preparation sound/soc/adi/axi-i2s.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/sound/soc/adi/axi-i2s.c b/sound/soc/adi/axi-i2s.c index 7752860..4c23381 100644 --- a/sound/soc/adi/axi-i2s.c +++ b/sound/soc/adi/axi-i2s.c @@ -240,6 +240,8 @@ static int axi_i2s_probe(struct platform_device *pdev) if (ret) goto err_clk_disable; + return 0; + err_clk_disable: clk_disable_unprepare(i2s->clk); return ret; -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/