Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751574AbaLaQnP (ORCPT ); Wed, 31 Dec 2014 11:43:15 -0500 Received: from cpsmtpb-ews07.kpnxchange.com ([213.75.39.10]:49951 "EHLO cpsmtpb-ews07.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbaLaQnJ (ORCPT ); Wed, 31 Dec 2014 11:43:09 -0500 Message-ID: <1420044185.9624.18.camel@x220> Subject: Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable" From: Paul Bolle To: Jiri Kosina Cc: Linus Torvalds , Borislav Petkov , "Grumbach, Emmanuel" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "egrumbach@gmail.com" , "peter@hurleysoftware.com" , "ilw@linux.intel.com" , "Berg, Johannes" , Larry Finger Date: Wed, 31 Dec 2014 17:43:05 +0100 In-Reply-To: References: <54A2B807.1020202@hurleysoftware.com> <0BA3FCBA62E2DC44AF3030971E174FB31B5DC915@hasmsx107.ger.corp.intel.com> <1419971304.30412.0.camel@egrumbacBox> <20141230212326.GA29263@pd.tnic> <54A328C2.5080606@lwfinger.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 31 Dec 2014 16:43:06.0297 (UTC) FILETIME=[DA23DA90:01D02518] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2014-12-30 at 23:52 +0100, Jiri Kosina wrote: > This reverts commit 24a0aa212ee2dbe44360288684478d76a8e20a0a. > > It's causing severe userspace breakage. Namely, all the utilities > from wireless-utils which are relying on CONFIG_WEXT (which means > tools like 'iwconfig', 'iwlist', etc) are not working anymore. There > is a 'iw' utility in newer wireless-tools, which is supposed to be > a replacement for all the "deprecated" binaries, but it's far away > from being massively adopted. > > Please see [1] for example of the userspace breakage this is causing. > > In addition to that, Larry Finger reports [2] that this patch is also > causing ipw2200 driver being impossible to build. > > To me this clearly shows that CONFIG_WEXT is far, far away from being > "deprecated enough" to be removed. > > [1] http://thread.gmane.org/gmane.linux.kernel/1857010 > [2] http://thread.gmane.org/gmane.linux.network/343688 So [2] already entered mainline as commit dddd60220f41 ("ipw2200: select CFG80211_WEXT"). As this revert has now been applied, I think my patch should now be reverted too. But I don't think it's a good idea to submit a patch, however trivial, in the last hours before new year. So I'll have a look into this in the first days of next year. > Signed-off-by: Jiri Kosina > --- > net/wireless/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig > index 22ba971..29c8675 100644 > --- a/net/wireless/Kconfig > +++ b/net/wireless/Kconfig > @@ -175,7 +175,7 @@ config CFG80211_INTERNAL_REGDB > Most distributions have a CRDA package. So if unsure, say N. > > config CFG80211_WEXT > - bool > + bool "cfg80211 wireless extensions compatibility" > depends on CFG80211 > select WEXT_CORE > help Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/