Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751529AbaLaUzM (ORCPT ); Wed, 31 Dec 2014 15:55:12 -0500 Received: from mail-ig0-f180.google.com ([209.85.213.180]:58408 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751362AbaLaUzJ (ORCPT ); Wed, 31 Dec 2014 15:55:09 -0500 MIME-Version: 1.0 In-Reply-To: <1418302951-9309-2-git-send-email-octavian.purdila@intel.com> References: <1418302951-9309-1-git-send-email-octavian.purdila@intel.com> <1418302951-9309-2-git-send-email-octavian.purdila@intel.com> Date: Wed, 31 Dec 2014 21:55:08 +0100 Message-ID: Subject: Re: [PATCH 1/3] gpio: dln2: fix issue when an IRQ is unmasked then enabled From: Linus Walleij To: Octavian Purdila Cc: Lee Jones , Johan Hovold , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 986 Lines: 28 On Thu, Dec 11, 2014 at 2:02 PM, Octavian Purdila wrote: > As noticed during suspend/resume operations, the IRQ can be unmasked > then disabled in suspend and eventually enabled in resume, but without > being unmasked. > > The current implementation does not take into account interactions > between mask/unmask and enable/disable interrupts, and thus in the > above scenarios the IRQs remain unactive. > > To fix this we removed the enable/disable operations as they fallback > to mask/unmask anyway. > > We also remove the pending bitmaks as it is already done in irq_data > (i.e. IRQS_PENDING). > > Signed-off-by: Octavian Purdila Patch applied for fixes. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/