Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751966AbbAAAVn (ORCPT ); Wed, 31 Dec 2014 19:21:43 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:47807 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507AbbAAAVm (ORCPT ); Wed, 31 Dec 2014 19:21:42 -0500 Date: Wed, 31 Dec 2014 19:21:34 -0500 (EST) Message-Id: <20141231.192134.2243740801309285028.davem@davemloft.net> To: xuyongjiande@163.com Cc: shahed.shaikh@qlogic.com, Dept-GELinuxNICDev@qlogic.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xuyongjiande@gmail.com Subject: Re: [PATCH] qlcnic: Fix return value in qlcnic_probe() From: David Miller In-Reply-To: <1419926626-26624-1-git-send-email-xuyongjiande@163.com> References: <1419926626-26624-1-git-send-email-xuyongjiande@163.com> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Wed, 31 Dec 2014 16:21:41 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 553 Lines: 16 From: xuyongjiande@163.com Date: Tue, 30 Dec 2014 16:03:46 +0800 > From: Yongjian Xu > > If the check of adapter fails and goes into the 'else' branch, the > return value 'err' should not still be zero. > > Signed-off-by: Yongjian Xu Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/