Date: Sun, 1 Feb 2015 11:30:13 -0800
From: Jeremiah Mahler <jmmahler@gmail.com>
To: "Theodore Ts'o" <tytso@mit.edu>, linux-kernel@vger.kernel.org
Subject: Re: [BUG, bisect] hang when copying large file to disc
Message-ID: <20150201193013.GA1306@hudson.localdomain>
Mail-Followup-To: Jeremiah Mahler <jmmahler@gmail.com>,
	Theodore Ts'o <tytso@mit.edu>, linux-kernel@vger.kernel.org
References: <20150131034051.GA1289@hudson.localdomain>
 <20150201020230.GA3070@thunk.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150201020230.GA3070@thunk.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1252
Lines: 39

Ted,

On Sat, Jan 31, 2015 at 09:02:30PM -0500, Theodore Ts'o wrote:
> On Fri, Jan 30, 2015 at 07:40:51PM -0800, Jeremiah Mahler wrote:
> > 
[...]
> 
> Thanks for the bug report.  I was able to reproduce the problem, and
> found the problem.  Unfortunately I accidentally introduce this in my
> most recent patchset.  I'll fix it up, but here is the patch until I
> get the a new version pushed out.
> 
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 82c2984..0046861 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -1192,9 +1192,9 @@ void __mark_inode_dirty(struct inode *inode, int flags)
>  
>  		trace_writeback_dirty_inode(inode, flags);
>  	}
> -	dirtytime = flags & I_DIRTY_TIME;
>  	if (flags & I_DIRTY_INODE)
>  		flags &= ~I_DIRTY_TIME;
> +	dirtytime = flags & I_DIRTY_TIME;
>  
>  	/*
>  	 * Paired with smp_mb() in __writeback_single_inode() for the
> 
> 	   	       		   			      	  - Ted

That solved the problem.  Thanks for the quick fix.

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/