Message-ID: <1422822955.12856.7.camel@perches.com>
Subject: Re: checkpatch: length of git commit IDs
From: Joe Perches <joe@perches.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux-kernel@vger.kernel.org
Date: Sun, 01 Feb 2015 12:35:55 -0800
In-Reply-To: <20150201213001.06ae0fd7@kant>
References: <20150201205916.0f321555@kant>
	 <1422821345.12856.1.camel@perches.com> <20150201213001.06ae0fd7@kant>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1184
Lines: 31

On Sun, 2015-02-01 at 21:30 +0100, Stefan Richter wrote:
> On Feb 01 Joe Perches wrote:
> > On Sun, 2015-02-01 at 20:59 +0100, Stefan Richter wrote:
> > > I was just told that 12 is less than 12:
> > > 
> > > > ERROR: Please use 12 or more chars for the git commit ID like: 'Commit
> > > > 01234567890ab ("commit description")' #5: 
> > > > Commit 2a48fc0ab242 "block: autoconvert trivial BKL users to private
> > 
> > Yeah, that message isn't very descriptive.
> > 
> > It really wants parentheses around the commit
> > message like:
> > 
> > Commit 2a48fc0ab242 ("block: autoconvert trivial BKL users to private
> > 
> > Try the version in -next.  I think it has  a
> > better message description.
> 
> Thanks for the tip; this works for me.  (checkpatch.pl from current -next
> does actually not complain about the line without parentheses.)

Hmm, I think that should be a defect.

Can you send me your git format-patch output please?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/