Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754390AbbBAV0V (ORCPT ); Sun, 1 Feb 2015 16:26:21 -0500 Received: from mail.kmu-office.ch ([178.209.48.109]:55538 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753493AbbBAV0T (ORCPT ); Sun, 1 Feb 2015 16:26:19 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Sun, 01 Feb 2015 22:25:56 +0100 From: Stefan Agner To: Stephen Boyd Cc: Thomas Gleixner , Jason Cooper , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Russell King Subject: Re: [PATCH] irqchip: gic: Don't complain in =?UTF-8?Q?gic=5Fget=5Fcpumask=28=29=20if=20UP=20system?= In-Reply-To: <1422665010-5854-1-git-send-email-sboyd@codeaurora.org> References: <1422665010-5854-1-git-send-email-sboyd@codeaurora.org> Message-ID: <9143d197d772c6e6ee10fd54bdcd557b@agner.ch> User-Agent: Roundcube Webmail/1.0.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1579 Lines: 43 On 2015-01-31 01:43, Stephen Boyd wrote: > In a uniprocessor implementation the interrupt processor targets > registers are read-as-zero/write-ignored (RAZ/WI). Unfortunately > gic_get_cpumask() will print a critical message saying > > GIC CPU mask not found - kernel will fail to boot. > > if these registers all read as zero, but there won't actually be > a problem on uniprocessor systems and the kernel will boot just > fine. Skip this check if we're running a UP kernel or if we > detect that the hardware only supports a single processor. Does the job for my device too, thx. Acked-by: Stefan Agner > > Acked-by: Nicolas Pitre > Cc: Russell King > Cc: Stefan Agner > Signed-off-by: Stephen Boyd > --- > drivers/irqchip/irq-gic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c > index d617ee5a3d8a..1b70e0de0f6e 100644 > --- a/drivers/irqchip/irq-gic.c > +++ b/drivers/irqchip/irq-gic.c > @@ -346,7 +346,7 @@ static u8 gic_get_cpumask(struct gic_chip_data *gic) > break; > } > > - if (!mask) > + if (!mask && num_possible_cpus() > 1) > pr_crit("GIC CPU mask not found - kernel will fail to boot.\n"); > > return mask; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/