Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754079AbbBBBG2 (ORCPT ); Sun, 1 Feb 2015 20:06:28 -0500 Received: from mga03.intel.com ([134.134.136.65]:59672 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752029AbbBBBGZ (ORCPT ); Sun, 1 Feb 2015 20:06:25 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,503,1418112000"; d="scan'208";a="671227477" From: "Wu, Feng" To: "H. Peter Anvin" , "tglx@linutronix.de" , "mingo@redhat.com" , "x86@kernel.org" , "gleb@kernel.org" , "pbonzini@redhat.com" , "dwmw2@infradead.org" , "joro@8bytes.org" , "alex.williamson@redhat.com" , "jiang.liu@linux.intel.com" CC: "eric.auger@linaro.org" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "kvm@vger.kernel.org" , "Wu, Feng" Subject: RE: [v3 21/26] x86, irq: Define a global vector for VT-d Posted-Interrupts Thread-Topic: [v3 21/26] x86, irq: Define a global vector for VT-d Posted-Interrupts Thread-Index: AQHQPLlXtqE7D8Cfr0+qBD3/PCzPH5zcj0Eg Date: Mon, 2 Feb 2015 01:06:11 +0000 Message-ID: References: <1418397300-10870-1-git-send-email-feng.wu@intel.com> <1418397300-10870-22-git-send-email-feng.wu@intel.com> <54CBCB11.401@zytor.com> In-Reply-To: <54CBCB11.401@zytor.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t1216eLd032447 Content-Length: 1519 Lines: 40 > -----Original Message----- > From: H. Peter Anvin [mailto:hpa@zytor.com] > Sent: Saturday, January 31, 2015 2:19 AM > To: Wu, Feng; tglx@linutronix.de; mingo@redhat.com; x86@kernel.org; > gleb@kernel.org; pbonzini@redhat.com; dwmw2@infradead.org; > joro@8bytes.org; alex.williamson@redhat.com; jiang.liu@linux.intel.com > Cc: eric.auger@linaro.org; linux-kernel@vger.kernel.org; > iommu@lists.linux-foundation.org; kvm@vger.kernel.org > Subject: Re: [v3 21/26] x86, irq: Define a global vector for VT-d > Posted-Interrupts > > On 12/12/2014 07:14 AM, Feng Wu wrote: > > Currently, we use a global vector as the Posted-Interrupts > > Notification Event for all the vCPUs in the system. We need > > to introduce another global vector for VT-d Posted-Interrtups, > > which will be used to wakeup the sleep vCPU when an external > > interrupt from a direct-assigned device happens for that vCPU. > > > > Signed-off-by: Feng Wu > > > > > #ifdef CONFIG_HAVE_KVM > > +void (*wakeup_handler_callback)(void) = NULL; > > +EXPORT_SYMBOL_GPL(wakeup_handler_callback); > > + > > Stylistic nitpick: we generally don't explicitly initialize > global/static pointer variables to NULL (that happens automatically anyway.) > > Other than that, > > Acked-by: H. Peter Anvin Thanks a lot for your review, Peter! Thanks, Feng ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?