Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754423AbbBBBJY (ORCPT ); Sun, 1 Feb 2015 20:09:24 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:63947 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbbBBBJX (ORCPT ); Sun, 1 Feb 2015 20:09:23 -0500 Date: Mon, 2 Feb 2015 10:09:14 +0900 From: Minchan Kim To: Ganesh Mahendran Cc: Nitin Gupta , Andrew Morton , Linux-MM , linux-kernel Subject: Re: [PATCH] mm/zsmalloc: avoid unnecessary iteration when freeing size_class Message-ID: <20150202010904.GA6402@blaptop> References: <1422107403-10071-1-git-send-email-opensource.ganesh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1125 Lines: 30 Hello Ganesh, On Sat, Jan 31, 2015 at 04:59:58PM +0800, Ganesh Mahendran wrote: > ping. > > 2015-01-24 21:50 GMT+08:00 Ganesh Mahendran : > > The pool->size_class[i] is assigned with the i from (zs_size_classes - 1) to 0. > > So if we failed in zs_create_pool(), we only need to iterate from (zs_size_classes - 1) > > to i, instead of from 0 to (zs_size_classes - 1) > > No functionality has been changed. This patch just avoids some > necessary iteration. Sorry for the delay. Did you saw any performance problem? I know it would be better than old but your assumption depends on the implmentation of zs_create_pool so if we changes(for example, revert 9eec4cd if compaction works well), your patch would be void. If it's not a critical, I'd like to remain it as generic and doesn't contaminate git-blame. Thanks. -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/