Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755140AbbBBEJp (ORCPT ); Sun, 1 Feb 2015 23:09:45 -0500 Received: from mail-ob0-f175.google.com ([209.85.214.175]:64312 "EHLO mail-ob0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754756AbbBBEJn (ORCPT ); Sun, 1 Feb 2015 23:09:43 -0500 MIME-Version: 1.0 In-Reply-To: <54CEF7AA.80401@oracle.com> References: <54CEECF7.7020504@oracle.com> <54CEF123.5050106@oracle.com> <54CEF574.6040404@oracle.com> <54CEF7AA.80401@oracle.com> Date: Mon, 2 Feb 2015 09:39:42 +0530 Message-ID: Subject: Re: [PATCH Resend] cpufreq: Set cpufreq_cpu_data to NULL before putting kobject From: Viresh Kumar To: ethan zhao Cc: Rafael Wysocki , santosh shilimkar , Linaro Kernel Mailman List , "linux-pm@vger.kernel.org" , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1117 Lines: 37 On 2 February 2015 at 09:36, ethan zhao wrote: > Is that an idea it supposed to be or fact ? > > if (!cpufreq_suspended) > cpufreq_policy_free(policy); > > static void cpufreq_policy_free(struct cpufreq_policy *policy) > { > free_cpumask_var(policy->related_cpus); > free_cpumask_var(policy->cpus); > kfree(policy); > } > > It seems you just think about it ideally in mind. if (!cpufreq_suspended) cpufreq_policy_put_kobj(policy); static void cpufreq_policy_put_kobj(struct cpufreq_policy *policy) { ... kobject_put(kobj); /* * We need to make sure that the underlying kobj is * actually not referenced anymore by anybody before we * proceed with unloading. */ pr_debug("waiting for dropping of refcount\n"); wait_for_completion(cmp); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/