Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755184AbbBBI2w (ORCPT ); Mon, 2 Feb 2015 03:28:52 -0500 Received: from regular1.263xmail.com ([211.150.99.138]:40360 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754344AbbBBI2v (ORCPT ); Mon, 2 Feb 2015 03:28:51 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: rockchip-discuss@chromium.org X-SENDER-IP: 192.253.240.203 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <696282892cfcc5f135d3552c9848b647> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <54CF3520.7080301@rock-chips.com> Date: Mon, 02 Feb 2015 03:28:16 -0500 From: Yang Kuankuan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Daniel Kurtz CC: David Airlie , Russell King , Philipp Zabel , Fabio Estevam , Shawn Guo , Rob Clark , Mark Yao , Daniel Vetter , dri-devel , "linux-kernel@vger.kernel.org" , dbehr@chromoum.org, =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= , Douglas Anderson , =?UTF-8?B?U3TDqXBoYW5lIE1hcmNoZXNpbg==?= , rockchip-discuss Subject: Re: [PATCH v2 05/12] drm: rockchip/vop: filter interlace display mode References: <1422617031-25098-1-git-send-email-ykk@rock-chips.com> <1422617388-25476-1-git-send-email-ykk@rock-chips.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2128 Lines: 60 On 02/02/2015 03:00 AM, Daniel Kurtz wrote: > Hi ykk, > > On Fri, Jan 30, 2015 at 7:29 PM, Yakir Yang wrote: >> RK3288's VOP do not support INTERLACE display mode, so we should >> remove those modes out of mode_ok list. >> >> Signed-off-by: Yakir Yang > > Reviewed-by: Daniel Kurtz > > Can you move this patch out of your hdmi audio patch set, and send it > separately? > This fix is independent of the others. > > Thanks! > Okay. : ) >> --- >> Changes in v2: >> - filter interlace display mode for rockchip vop >> >> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> index 9a5c571..bedab42 100644 >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> @@ -808,7 +808,8 @@ static bool vop_crtc_mode_fixup(struct drm_crtc *crtc, >> const struct drm_display_mode *mode, >> struct drm_display_mode *adjusted_mode) >> { >> - if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0) >> + if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0 || >> + (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE)) >> return false; >> >> return true; >> -- >> 2.1.2 >> >> >> -- >> You received this message because you are subscribed to the Google Groups "rockchip-discuss" group. >> To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/rockchip-discuss/1422617388-25476-1-git-send-email-ykk%40rock-chips.com. >> >> To unsubscribe from this group and stop receiving emails from it, send an email to rockchip-discuss+unsubscribe@chromium.org. > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/