Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964877AbbBBJCR (ORCPT ); Mon, 2 Feb 2015 04:02:17 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:14188 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932818AbbBBJCO (ORCPT ); Mon, 2 Feb 2015 04:02:14 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 02 Feb 2015 00:51:20 -0800 Message-ID: <54CF3CC5.6030204@nvidia.com> Date: Mon, 2 Feb 2015 14:30:53 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Nicholas Mc Guire , Mark Brown CC: Stephen Warren , Thierry Reding , Alexandre Courbot , , , Subject: Re: [PATCH 1/2] spi: tegra20-sflash: cleanup wait_for_completion return handling References: <1422795604-29004-1-git-send-email-hofrat@osadl.org> In-Reply-To: <1422795604-29004-1-git-send-email-hofrat@osadl.org> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRHKMAIL102.nvidia.com (10.25.59.16) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 916 Lines: 27 On Sunday 01 February 2015 06:30 PM, Nicholas Mc Guire wrote: > return type of wait_for_completion_timeout is unsigned long not int, this > patch adds an appropriate variable and fixes up the assignment. > As the string in dev_err already states "timeout" there > is little point in printing the 0 here. > > Signed-off-by: Nicholas Mc Guire Looks good to me. Thanks for fixing this. I think it is good if we fix the typo here also. Acked-by: Laxman Dewangan > > + if (WARN_ON(dma_timeout == 0)) { > dev_err(tsd->dev, > - "spi trasfer timeout, err %d\n", ret); > + "spi trasfer timeout\n"); trasfer -> transfer. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/