Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933113AbbBBJFT (ORCPT ); Mon, 2 Feb 2015 04:05:19 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:13216 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932677AbbBBJFP (ORCPT ); Mon, 2 Feb 2015 04:05:15 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Mon, 02 Feb 2015 01:04:28 -0800 Message-ID: <54CF3D95.3060607@nvidia.com> Date: Mon, 2 Feb 2015 14:34:21 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Nicholas Mc Guire , Mark Brown CC: Stephen Warren , Thierry Reding , Alexandre Courbot , , , Subject: Re: [PATCH] spi: tegra114: cleanup wait_for_completion return handling References: <1422798911-1626-1-git-send-email-hofrat@osadl.org> In-Reply-To: <1422798911-1626-1-git-send-email-hofrat@osadl.org> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRHKMAIL102.nvidia.com (10.25.59.16) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 843 Lines: 20 On Sunday 01 February 2015 07:25 PM, Nicholas Mc Guire wrote: > return type of wait_for_completion_timeout is unsigned long not int, this > patch adds an appropriate variable and fixes up the assignment. > As the string in dev_err already explicitly states "timeout" there > is little point in printing the 0 here which also just says "timeout". > Looks good to me. Thanks for fixing this. I think it is good if we fix the typo here also. Acked-by: Laxman Dewangan > + if (WARN_ON(dma_timeout == 0)) { > + dev_err(tspi->dev, "spi trasfer timeout\n"); trasfer->transfer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/