Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932938AbbBBJQN (ORCPT ); Mon, 2 Feb 2015 04:16:13 -0500 Received: from www.osadl.org ([62.245.132.105]:46577 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752333AbbBBJQJ (ORCPT ); Mon, 2 Feb 2015 04:16:09 -0500 From: Nicholas Mc Guire To: Laxman Dewangan Cc: Mark Brown , Stephen Warren , Thierry Reding , Alexandre Courbot , linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH v2] spi: tegra114: cleanup wait_for_completion return handling Date: Mon, 2 Feb 2015 04:11:49 -0500 Message-Id: <1422868311-10929-1-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 1.7.10.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1823 Lines: 54 return type of wait_for_completion_timeout is unsigned long not int, this patch adds an appropriate variable and fixes up the assignment. As the string in dev_err already explicitly states "timeout" there is little point in printing the 0 here which also just says "timeout". Signed-off-by: Nicholas Mc Guire --- v2: typo fixed as suggested by Laxman Dewangan This patch was only compile tested with tegra_defconfig (implies CONFIG_SPI_TEGRA114=y) Patch is against 3.19.0-rc6 -next-20150130 drivers/spi/spi-tegra114.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c index 73779ce..0dfb422 100644 --- a/drivers/spi/spi-tegra114.c +++ b/drivers/spi/spi-tegra114.c @@ -807,6 +807,7 @@ static int tegra_spi_transfer_one_message(struct spi_master *master, struct spi_transfer *xfer; struct spi_device *spi = msg->spi; int ret; + unsigned long dma_timeout; bool skip = false; msg->status = 0; @@ -833,11 +834,10 @@ static int tegra_spi_transfer_one_message(struct spi_master *master, } is_first_msg = false; - ret = wait_for_completion_timeout(&tspi->xfer_completion, - SPI_DMA_TIMEOUT); - if (WARN_ON(ret == 0)) { - dev_err(tspi->dev, - "spi trasfer timeout, err %d\n", ret); + dma_timeout = wait_for_completion_timeout( + &tspi->xfer_completion, SPI_DMA_TIMEOUT); + if (WARN_ON(dma_timeout == 0)) { + dev_err(tspi->dev, "spi transfer timeout\n"); ret = -EIO; goto complete_xfer; } -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/