Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754351AbbBBMEB (ORCPT ); Mon, 2 Feb 2015 07:04:01 -0500 Received: from cmexedge1.emulex.com ([138.239.224.99]:9315 "EHLO CMEXEDGE1.ext.emulex.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751540AbbBBMD6 convert rfc822-to-8bit (ORCPT ); Mon, 2 Feb 2015 07:03:58 -0500 From: Selvin Xavier To: Rasmus Villemoes , Roland Dreier , Sean Hefty , Hal Rosenstock CC: "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 2/2] infiniband: Use unsigned for bit index Thread-Topic: [PATCH 2/2] infiniband: Use unsigned for bit index Thread-Index: AQHQMZq0V25WnkhWD0m1VVF3yj1FipzdMZug Date: Mon, 2 Feb 2015 12:03:31 +0000 Message-ID: <36AE2E863FF33A4F9FBBE296E34DBC8F5A096246@CMEXMB1.ad.emulex.com> References: <1421419196-4659-1-git-send-email-linux@rasmusvillemoes.dk> <1421419196-4659-2-git-send-email-linux@rasmusvillemoes.dk> In-Reply-To: <1421419196-4659-2-git-send-email-linux@rasmusvillemoes.dk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.226.192.248] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2111 Lines: 56 Acked-by: Selvin Xavier Thanks! > -----Original Message----- > From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma- > owner@vger.kernel.org] On Behalf Of Rasmus Villemoes > Sent: Friday, January 16, 2015 8:10 PM > To: Roland Dreier; Sean Hefty; Hal Rosenstock > Cc: Rasmus Villemoes; linux-rdma@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [PATCH 2/2] infiniband: Use unsigned for bit index > > In the expressions idx/32 and idx%32, both idx and 32 have signed type, and > unfortunately the C standard prescribes rounding to 0, so unless gcc can > prove that idx is non-negative, these cannot be implemented as simple shift > respectively mask operations. Help gcc by changing the type of idx to > unsigned - this cuts another few instructions from the generated code. > > Signed-off-by: Rasmus Villemoes > --- > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > index eff11e6c6183..61c3047f5170 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > @@ -1479,10 +1479,10 @@ mbx_err: > return status; > } > > -static void ocrdma_srq_toggle_bit(struct ocrdma_srq *srq, int idx) > +static void ocrdma_srq_toggle_bit(struct ocrdma_srq *srq, unsigned int > +idx) > { > - int i = idx / 32; > - unsigned int mask = (1 << (idx % 32)); > + unsigned int i = idx / 32; > + u32 mask = (1U << (idx % 32)); > > srq->idx_bit_fields[i] ^= mask; > } > -- > 2.1.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the > body of a message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/