Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933206AbbBBNhH (ORCPT ); Mon, 2 Feb 2015 08:37:07 -0500 Received: from mail-wg0-f47.google.com ([74.125.82.47]:63182 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755086AbbBBNhB (ORCPT ); Mon, 2 Feb 2015 08:37:01 -0500 From: Andreas Ruprecht To: Oleg Drokin Cc: Andreas Dilger , Greg Kroah-Hartman , HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Andreas Ruprecht Subject: [PATCH] staging: lustre: osc: Fix sparse warning about osc_init Date: Mon, 2 Feb 2015 14:36:43 +0100 Message-Id: <1422884203-27173-1-git-send-email-rupran@einserver.de> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1308 Lines: 38 When running sparse on the osc/ subdirectory, it shows the following warning: andreas@workbox:~/linux-next$ make C=1 M=drivers/staging/lustre/lustre/osc/ [...] drivers/staging/lustre/lustre/osc/osc_request.c:3335:12: warning: symbol 'osc_init' was not declared. Should it be static? [...] As this is the module init function, it can (and should) be declared static. Signed-off-by: Andreas Ruprecht --- drivers/staging/lustre/lustre/osc/osc_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/osc/osc_request.c b/drivers/staging/lustre/lustre/osc/osc_request.c index b9450b9..0adfa70 100644 --- a/drivers/staging/lustre/lustre/osc/osc_request.c +++ b/drivers/staging/lustre/lustre/osc/osc_request.c @@ -3332,7 +3332,7 @@ extern struct lu_kmem_descr osc_caches[]; extern spinlock_t osc_ast_guard; extern struct lock_class_key osc_ast_guard_class; -int __init osc_init(void) +static int __init osc_init(void) { struct lprocfs_static_vars lvars = { NULL }; int rc; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/