Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932998AbbBBQpd (ORCPT ); Mon, 2 Feb 2015 11:45:33 -0500 Received: from smtp5.ore.mailhop.org ([54.186.10.118]:45086 "EHLO smtp5.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932463AbbBBQpa (ORCPT ); Mon, 2 Feb 2015 11:45:30 -0500 X-Greylist: delayed 1777 seconds by postgrey-1.27 at vger.kernel.org; Mon, 02 Feb 2015 11:45:30 EST X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 104.193.169.186 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX1/jSFRPvfZUmVZ141sQ+uZ8 Date: Mon, 2 Feb 2015 08:12:37 -0800 From: Tony Lindgren To: Geert Uytterhoeven Cc: Mike Turquette , Tomeu Vizoso , Stephen Boyd , Linux MIPS Mailing List , "linux-doc@vger.kernel.org" , Chao Xie , Haojian Zhuang , Boris Brezillon , Russell King , Jonathan Corbet , Emilio L??pez , Linux-sh list , Alex Elder , Zhangfei Gao , Bintian Wang , Matt Porter , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Ralf Baechle , Tero Kristo , Manuel Lauss , Maxime Ripard , Javier Martinez Canillas Subject: Re: [PATCH v13 4/6] clk: Add rate constraints to clocks Message-ID: <20150202161237.GG16250@atomide.com> References: <1422011024-32283-1-git-send-email-tomeu.vizoso@collabora.com> <1422011024-32283-5-git-send-email-tomeu.vizoso@collabora.com> <54CA8662.7040008@codeaurora.org> <20150131013158.GA4323@codeaurora.org> <20150201221856.421.6151@quantum> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5426 Lines: 107 * Geert Uytterhoeven [150202 00:03]: > On Sun, Feb 1, 2015 at 11:18 PM, Mike Turquette wrote: > > Quoting Tomeu Vizoso (2015-01-31 10:36:22) > >> On 31 January 2015 at 02:31, Stephen Boyd wrote: > >> > On 01/29, Stephen Boyd wrote: > >> >> On 01/29/15 05:31, Geert Uytterhoeven wrote: > >> >> > Hi Tomeu, Mike, > >> >> > > >> >> > On Fri, Jan 23, 2015 at 12:03 PM, Tomeu Vizoso > >> >> > wrote: > >> >> >> --- a/drivers/clk/clk.c > >> >> >> +++ b/drivers/clk/clk.c > >> >> >> @@ -2391,25 +2543,24 @@ int __clk_get(struct clk *clk) > >> >> >> return 1; > >> >> >> } > >> >> >> > >> >> >> -static void clk_core_put(struct clk_core *core) > >> >> >> +void __clk_put(struct clk *clk) > >> >> >> { > >> >> >> struct module *owner; > >> >> >> > >> >> >> - owner = core->owner; > >> >> >> + if (!clk || WARN_ON_ONCE(IS_ERR(clk))) > >> >> >> + return; > >> >> >> > >> >> >> clk_prepare_lock(); > >> >> >> - kref_put(&core->ref, __clk_release); > >> >> >> + > >> >> >> + hlist_del(&clk->child_node); > >> >> >> + clk_core_set_rate_nolock(clk->core, clk->core->req_rate); > >> >> > At this point, clk->core->req_rate is still zero, causing > >> >> > cpg_div6_clock_round_rate() to be called with a zero "rate" parameter, > >> >> > e.g. on r8a7791: > >> >> > >> >> Hmm.. I wonder if we should assign core->req_rate to be the same as > >> >> core->rate during __clk_init()? That would make this call to > >> >> clk_core_set_rate_nolock() a nop in this case. > >> >> > >> > > >> > Here's a patch to do this > >> > > >> > ---8<---- > >> > From: Stephen Boyd > >> > Subject: [PATCH] clk: Assign a requested rate by default > >> > > >> > We need to assign a requested rate here so that we avoid > >> > requesting a rate of 0 on clocks when we remove clock consumers. > >> > >> Hi, this looks good to me. > >> > >> Reviewed-by: Tomeu Vizoso > > > > It seems to fix the total boot failure on OMAPs, and hopefully does the > > same for SH Mobile and others. I've squashed this into Tomeu's rate > > constraints patch to maintain bisect. > > Yes, it fixes shmobile. .round_rate() is now called with a sane value of rate. Looks like next-20150202 now produces tons of the following errors, these from omap4: [ 10.568206] ------------[ cut here ]------------ [ 10.568206] WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:925 clk_disable+0x28/0x34() [ 10.568237] Modules linked in: [ 10.568237] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 3.19.0-rc6-next-20150202 #2037 [ 10.568237] Hardware name: Generic OMAP4 (Flattened Device Tree) [ 10.568267] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [ 10.568267] [] (show_stack) from [] (dump_stack+0x84/0x9c) [ 10.568267] [] (dump_stack) from [] (warn_slowpath_common+0x7c/0xb8) [ 10.568298] [] (warn_slowpath_common) from [] (warn_slowpath_null+0x1c/0x24) [ 10.568298] [] (warn_slowpath_null) from [] (clk_disable+0x28/0x34) [ 10.568328] [] (clk_disable) from [] (_disable_clocks+0x18/0x68) [ 10.568328] [] (_disable_clocks) from [] (_idle+0x10c/0x214) [ 10.568328] [] (_idle) from [] (_setup+0x338/0x410) [ 10.568359] [] (_setup) from [] (omap_hwmod_for_each+0x34/0x60) [ 10.568359] [] (omap_hwmod_for_each) from [] (__omap_hwmod_setup_all+0x30/0x40) [ 10.568389] [] (__omap_hwmod_setup_all) from [] (do_one_initcall+0x80/0x1dc) [ 10.568389] [] (do_one_initcall) from [] (kernel_init_freeable+0x204/0x2d0) [ 10.568420] [] (kernel_init_freeable) from [] (kernel_init+0x8/0xec) [ 10.568420] [] (kernel_init) from [] (ret_from_fork+0x14/0x24) [ 10.568420] ---[ end trace cb88537fdc8fa211 ]--- [ 10.568450] ------------[ cut here ]------------ [ 10.568450] WARNING: CPU: 0 PID: 1 at arch/arm/mach-omap2/dpll3xxx.c:436 omap3_noncore_dpll_enable+0xdc/0 x10c() [ 10.568450] Modules linked in: [ 10.568481] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 3.19.0-rc6-next-20150202 #2037 [ 10.568481] Hardware name: Generic OMAP4 (Flattened Device Tree) [ 10.568481] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [ 10.568511] [] (show_stack) from [] (dump_stack+0x84/0x9c) [ 10.568511] [] (dump_stack) from [] (warn_slowpath_common+0x7c/0xb8) [ 10.568511] [] (warn_slowpath_common) from [] (warn_slowpath_null+0x1c/0x24) [ 10.568542] [] (warn_slowpath_null) from [] (omap3_noncore_dpll_enable+0xdc/0x10c) [ 10.568542] [] (omap3_noncore_dpll_enable) from [] (clk_core_enable+0x60/0x9c) [ 10.568572] [] (clk_core_enable) from [] (clk_core_enable+0x40/0x9c) [ 10.568572] ---[ end trace cb88537fdc8fa212 ]--- ... Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/