Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753897AbbBBRYg (ORCPT ); Mon, 2 Feb 2015 12:24:36 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:33160 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752563AbbBBRYe (ORCPT ); Mon, 2 Feb 2015 12:24:34 -0500 Date: Mon, 2 Feb 2015 09:23:11 -0800 From: Guenter Roeck To: grygorii.strashko@linaro.org Cc: Jean Delvare , lm-sensors@lm-sensors.org, sumit.semwal@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH] hwmon: tmp102: add hibernation callbacks Message-ID: <20150202172311.GA22638@roeck-us.net> References: <1422897271-24068-1-git-send-email-grygorii.strashko@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422897271-24068-1-git-send-email-grygorii.strashko@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020204.54CFB2D1.01F9,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 6 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1845 Lines: 51 On Mon, Feb 02, 2015 at 07:14:31PM +0200, grygorii.strashko@linaro.org wrote: > From: Grygorii Strashko > > Setting a dev_pm_ops suspend/resume pair but not a set of > hibernation functions means those pm functions will not be > called upon hibernation. > Fix this by using SIMPLE_DEV_PM_OPS, which appropriately > assigns the suspend and hibernation handlers. > > Signed-off-by: Grygorii Strashko > --- > drivers/hwmon/tmp102.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c > index 6748b45..4f790f5 100644 > --- a/drivers/hwmon/tmp102.c > +++ b/drivers/hwmon/tmp102.c > @@ -281,17 +281,10 @@ static int tmp102_resume(struct device *dev) > config &= ~TMP102_CONF_SD; > return i2c_smbus_write_word_swapped(client, TMP102_CONF_REG, config); > } > - > -static const struct dev_pm_ops tmp102_dev_pm_ops = { > - .suspend = tmp102_suspend, > - .resume = tmp102_resume, > -}; > - > -#define TMP102_DEV_PM_OPS (&tmp102_dev_pm_ops) > -#else > -#define TMP102_DEV_PM_OPS NULL > #endif /* CONFIG_PM */ > > +SIMPLE_DEV_PM_OPS(tmp102_dev_pm_ops, tmp102_suspend, tmp102_resume); > + SIMPLE_DEV_PM_OPS is defined in the context of CONFIG_PM_SLEEP, while tmp102_suspend and tmp102_resume above are defined in the context of CONFIG_PM. This will result in situations where the functions are defined but not used, resulting in build warnings. Please change the condition in the driver to #ifdef CONFIG_PM_SLEEP to avoid this problem. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/