Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755098AbbBBUPf (ORCPT ); Mon, 2 Feb 2015 15:15:35 -0500 Received: from lvps176-28-13-145.dedicated.hosteurope.de ([176.28.13.145]:48573 "EHLO lvps176-28-13-145.dedicated.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753260AbbBBUPe (ORCPT ); Mon, 2 Feb 2015 15:15:34 -0500 From: Tim Sander To: Bjorn Helgaas Cc: "linux-kernel@vger.kernel.org" , Linus Torvalds , "linux-pci@vger.kernel.org" , "alex.williamson@redhat.com" Subject: Re: [PATCH] 3.19-rc7: add quirk for 1c28:0122 (rev 14) SATA controller Date: Mon, 02 Feb 2015 21:15:22 +0100 Message-ID: <20929701.uenxAK52C7@hydra> Organization: Sander & Lightning User-Agent: KMail/4.14.2 (Linux/3.19.0-rc5-00134-gf8de05c; KDE/4.14.2; x86_64; ; ) In-Reply-To: References: <1561014.NTLJeH8lPH@dabox> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1737 Lines: 42 Hi Bjorn Am Montag 02 Februar 2015, 08:55:33 schrieb Bjorn Helgaas: > [+cc Alex] > > On Mon, Feb 2, 2015 at 5:29 AM, Tim Sander wrote: > > The long name for this device is > > Lite-On IT Corp. / Plextor M6e PCI Express SSD [Marvell 88SS9183] (rev 14) > > > > Background: the error description on bugzilla > > https://bugzilla.kernel.org/show_bug.cgi?id=42679 > > inspired me to check if my brand new m4 pci ssd could work with a quirk. > > Its device representation is not visible before this patch. > > After this patch it appears as a normal device. Formatting > > and mounting worked so far. > > > > Signed-off-by: Tim Sander > > Hi Tim, > > Thanks a lot for the patch. Can you open a new report at > http://bugzilla.kernel.org and attach the complete dmesg and "lspci > -vv" output without this patch, and also a dmesg log *with* this > patch? I like to keep a little documentation around in case we > restructure this code in the future. Basically its the same issue as the linked bug report, so reporting this twice seems a little backward to me? > Also, since the vendor and device IDs are used only once, we probably > won't add them to pci_ids.h (see the comment at the top of the file). > Just use the bare constants in the quirk. Mh, thats what i had first. For patch submission i created the header entries as it seemed cleaner as you can deduce the manufacturer from the names. But then its really not that important. Tim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/