Message-ID: <54CFF560.300@hurleysoftware.com>
Date: Mon, 02 Feb 2015 17:08:32 -0500
From: Peter Hurley <peter@hurleysoftware.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Clemens Ladisch <clemens@ladisch.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Stefan Richter <stefanr@s5r6.in-berlin.de>, devel@driverdev.osuosl.org,
        linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/fwserial: use correct vendor/version IDs
References: <54C940E0.5090906@ladisch.de> <54C9418F.1050600@ladisch.de>
In-Reply-To: <54C9418F.1050600@ladisch.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 989
Lines: 29

On 01/28/2015 03:07 PM, Clemens Ladisch wrote:
> The driver was using the vendor ID 0xd00d1e from the FireWire core.
> However, this ID was not registered, and invalid.
> 
> Instead, use the vendor/version IDs that now are officially assigned to
> firewire-serial:
> https://ieee1394.wiki.kernel.org/index.php/IEEE_OUI_Assignments

That's great that we have official OUIs now, but I have to NACK this
patch as is.

The problem is a host with the old OUIs will not recognize a remote
unit with the new OUIs, and vice versa.

Even though the new ids could be added to the unit driver's id_table,
(which would let hosts with the new OUI connect to either OUI remote),
it wouldn't let 3.19- hosts connect to 3.20+ hosts.

Regards,
Peter Hurley


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/