Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933639AbbBBWPt (ORCPT ); Mon, 2 Feb 2015 17:15:49 -0500 Received: from exprod5og110.obsmtp.com ([64.18.0.20]:42332 "EHLO mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755215AbbBBWPp (ORCPT ); Mon, 2 Feb 2015 17:15:45 -0500 MIME-Version: 1.0 In-Reply-To: <20150130061118.GA995@katana> References: <1412726809-7525-1-git-send-email-fkan@apm.com> <1412726809-7525-5-git-send-email-fkan@apm.com> <1894616.4yY7dajl4R@wuerfel> <20150130061118.GA995@katana> Date: Mon, 2 Feb 2015 14:15:44 -0800 Message-ID: Subject: Re: [PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform From: Feng Kan To: Wolfram Sang Cc: Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , patches , linux-i2c@vger.kernel.org, "linux-kernel@vger.kernel.org" , Hieu Le Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1023 Lines: 21 On Thu, Jan 29, 2015 at 10:11 PM, Wolfram Sang wrote: > >> > ctx->dev is probably the wrong device here. The i2c controller is not >> > DMA capable itself, you need to have a pointer to the device that actually >> > performs the DMA here. >> >> Arnd, I do agree this may not be the best identification. There is no >> representation for this on the Linux side. I could put it as NULL. However, >> there are other i2c bus drivers that seem to do the same thing. Please >> let me know what you think. > > For completeness: Those drivers need fixing! I have some doubts. I could hack up a dts node for the helper processor that is doing the dma. However, the dma master could be anything for that matter. I am not sure how I can write this in a generic manner. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/