Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933524AbbBCEgV (ORCPT ); Mon, 2 Feb 2015 23:36:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38519 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933156AbbBCEgU (ORCPT ); Mon, 2 Feb 2015 23:36:20 -0500 Date: Tue, 03 Feb 2015 04:43:55 +0008 From: Jason Wang Subject: Re: [PATCH v2 1/3] hv: hv_util: move vmbus_open() to a later place To: Dexuan Cui Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, kys@microsoft.com, vkuznets@redhat.com, haiyangz@microsoft.com Message-Id: <1422938155.6732.4@smtp.corp.redhat.com> In-Reply-To: <1422851718-2353-1-git-send-email-decui@microsoft.com> References: <1422851718-2353-1-git-send-email-decui@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1800 Lines: 65 On Mon, Feb 2, 2015 at 12:35 PM, Dexuan Cui wrote: > Before the line vmbus_open() returns, srv->util_cb can be already > running > and the variables, like util_fw_version, are needed by the > srv->util_cb. > > So we have to make sure the variables are initialized before the > vmbus_open(). > > CC: "K. Y. Srinivasan" > Reviewed-by: Vitaly Kuznetsov > Signed-off-by: Dexuan Cui > --- > > v2: > This is a RESEND. > I just added Vitaly's Reviewed-by. > > drivers/hv/hv_util.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c > index 3b9c9ef..c5be773 100644 > --- a/drivers/hv/hv_util.c > +++ b/drivers/hv/hv_util.c > @@ -340,12 +340,8 @@ static int util_probe(struct hv_device *dev, > > set_channel_read_state(dev->channel, false); > > - ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL, > 0, > - srv->util_cb, dev->channel); > - if (ret) > - goto error; > - > hv_set_drvdata(dev, srv); > + > /* > * Based on the host; initialize the framework and > * service version numbers we will negotiate. > @@ -365,6 +361,11 @@ static int util_probe(struct hv_device *dev, > hb_srv_version = HB_VERSION; > } > > + ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL, > 0, > + srv->util_cb, dev->channel); > + if (ret) > + goto error; > + > return 0; > > error: > -- > 1.9.1 Reviewed-by: Jason Wang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/