Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755495AbbBCH6f (ORCPT ); Tue, 3 Feb 2015 02:58:35 -0500 Received: from smtp2.provo.novell.com ([137.65.250.81]:41684 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752210AbbBCH6e (ORCPT ); Tue, 3 Feb 2015 02:58:34 -0500 Message-ID: <1422950306.12575.0.camel@stgolabs.net> Subject: Re: [PATCH 1/5] WIP: Add syscall unlinkat_s (currently x86* only) From: Davidlohr Bueso To: Alexander Holler Cc: Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 02 Feb 2015 23:58:26 -0800 In-Reply-To: <54D071AA.1030302@ahsoftware.de> References: <1422896713-25367-1-git-send-email-holler@ahsoftware.de> <1422896713-25367-2-git-send-email-holler@ahsoftware.de> <20150203060542.GZ29656@ZenIV.linux.org.uk> <54D071AA.1030302@ahsoftware.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.7 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1344 Lines: 34 On Tue, 2015-02-03 at 07:58 +0100, Alexander Holler wrote: > Am 03.02.2015 um 07:05 schrieb Al Viro: > > On Mon, Feb 02, 2015 at 06:05:09PM +0100, Alexander Holler wrote: > >> + if (inode) { > >> + // TODO: > >> + // if (inode is file and 's' flag is set) > >> + // secure = true; > >> + if (!secure) > >> + iput(inode); /* truncate the inode here */ > >> + else { > >> + struct super_block *sb = inode->i_sb; > >> + if (sb->s_op->set_secure_delete) > >> + sb->s_op->set_secure_delete(sb, true); > >> + // TODO: We should fail if secure isn't supported, > >> + // look up how that's possible here. > >> + iput(inode); /* truncate the inode here */ > >> + // TODO: check if sb is still valid after the inode is gone > >> + sync_filesystem(sb); > >> + if (sb->s_op->set_secure_delete) > >> + sb->s_op->set_secure_delete(sb, false); > >> + } > > > > Charming. Now, what exactly happens if two such syscalls overlap in time? > > What do you think will happen? I assume you haven't looked at how I've > implemented set_secure_delete(). CHarming. Chill, why don't you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/