Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754503AbbBCJRk (ORCPT ); Tue, 3 Feb 2015 04:17:40 -0500 Received: from mail.parknet.co.jp ([210.171.160.6]:54915 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751206AbbBCJRh (ORCPT ); Tue, 3 Feb 2015 04:17:37 -0500 X-Greylist: delayed 1570 seconds by postgrey-1.27 at vger.kernel.org; Tue, 03 Feb 2015 04:17:36 EST From: OGAWA Hirofumi To: "Michael Kerrisk \(man-pages\)" Cc: Heinrich Schuchardt , "linux-fsdevel\@vger.kernel.org" , lkml , linux-man Subject: Re: [PATCH v3 1/1] ioctl-fat.2: new manpage for the ioctl fat API References: <1422042884-10824-1-git-send-email-xypron.glpk@gmx.de> Date: Tue, 03 Feb 2015 17:51:23 +0900 In-Reply-To: (Michael Kerrisk's message of "Tue, 3 Feb 2015 09:25:50 +0100") Message-ID: <87k2zze5tg.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1478 Lines: 47 "Michael Kerrisk (man-pages)" writes: > Hello Heinrich and Ogawa, Hi, > On 23 January 2015 at 20:54, Heinrich Schuchardt wrote: >> The ioctl(2) system call may be used to retrieve information about >> the fat file system and to set file attributes. >> >> This new manpage describes the details. > > @Ogawa, as the FAT maintainer, might you be willing to review this page? for (;;) { /* * Read next directory entry. */ ret = ioctl( fd, VFAT_IOCTL_READDIR_BOTH, entry); /* * If an error occurs, the return value is -1. * If d_reclen is zero, the end of the directory * list has been reached. */ if (ret == -1 || entry[0].d_reclen == 0) break; Quick reviewed, and looks good. However, entry[0].d_reclen == 0 works as backward compatibility though. The example might be good to use usual way of getdents(). I.e., "ret" means -1 == error 0 == EOD 0 > how many bytes read Thanks. -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/