Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933957AbbBCMpn (ORCPT ); Tue, 3 Feb 2015 07:45:43 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48868 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752508AbbBCMpl (ORCPT ); Tue, 3 Feb 2015 07:45:41 -0500 Date: Tue, 3 Feb 2015 12:44:41 +0000 From: Mark Brown To: Manuel Lauss Cc: Bo Shen , Manuel Lauss , Liam Girdwood , Richard Purdie , patches@opensource.wolfsonmicro.com, linux-sound@vger.kernel.org, alsa-devel , linux-arm-kernel@lists.infradead.org, LKML Message-ID: <20150203124441.GK21293@sirena.org.uk> References: <1422934415-24957-1-git-send-email-voice.shen@atmel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="py4RQBuvJMmLuKXJ" Content-Disposition: inline In-Reply-To: X-Cookie: My LESLIE GORE record is BROKEN ... User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1571 Lines: 43 --py4RQBuvJMmLuKXJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 03, 2015 at 08:54:57AM +0100, Manuel Lauss wrote: > + wm8731->mclk = devm_clk_get(&spi->dev, "mclk"); > + if (IS_ERR(wm8731->mclk)) { > + wm8731->mclk = NULL; > + dev_warn(&spi->dev, "assuming static MCLK\n"); > + } This is broken for both deferred probe and in the case where the clock API genuinely returns a NULL clock. Other than that it's the kind of thing that we've done for some other drivers, though it's not good to have to do this. Check them for correct behaviour. The coding style is also not right for the whole patch and there's a lot of missing error checking. --py4RQBuvJMmLuKXJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJU0MK5AAoJECTWi3JdVIfQDKEH/0cfeB7iOzFR3+ko4cwSnoth 59h+3/agB1NnIiuOGG31HOcK0+YiW4hrE0lpz6kpHWXXfYrKXgd0IXChl2zixyBn 3ggVle1R7mnG3xgcq5iRUresTy59O3ShVoNxsse28lBPIOYcPvhZ7GuGuLUukQDJ K9b3rsrIaTQpLz/BeoVuEBkvCwTjFbHKE63mNjZsEGLDHlweaZ6aiQRhfr+qa6+d yPZFiRYPm8h8ZU9EYJ50GUmAxp/6IHwoEpKDHPYo7G4Pi+NkZWwKUmG8eA/RDUb1 6M3zdXFmksNIVJ2vs8FOMUsGrgI4VB8QSTus711U00GcmLKMWl1Y3lsUqtv38OQ= =88LY -----END PGP SIGNATURE----- --py4RQBuvJMmLuKXJ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/