Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755972AbbBCOOy (ORCPT ); Tue, 3 Feb 2015 09:14:54 -0500 Received: from mail-pa0-f48.google.com ([209.85.220.48]:62135 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754017AbbBCOOw (ORCPT ); Tue, 3 Feb 2015 09:14:52 -0500 Date: Tue, 3 Feb 2015 23:15:25 +0900 From: Sergey Senozhatsky To: Ganesh Mahendran Cc: Sergey Senozhatsky , sergey.senozhatsky.work@gmail.com, Minchan Kim , Andrew Morton , Jerome Marchand , linux-kernel Subject: Re: [PATCH] zram: fix umount-reset_store-mount race condition Message-ID: <20150203141525.GA1050@swordfish> References: <1422886120-16534-1-git-send-email-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 526 Lines: 18 Hello, On (02/03/15 22:05), Ganesh Mahendran wrote: > > zram->disksize = 0; > > - if (reset_capacity) > > - set_capacity(zram->disk, 0); > > How about keep this here? Protected by zram->init_lock. > set_capacity(zram->disk, 0); why? -ss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/