Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755931AbbBCOcO (ORCPT ); Tue, 3 Feb 2015 09:32:14 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:61439 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753473AbbBCOcM convert rfc822-to-8bit (ORCPT ); Tue, 3 Feb 2015 09:32:12 -0500 From: "Rafael J. Wysocki" To: Hanjun Guo Cc: Catalin Marinas , Olof Johansson , Arnd Bergmann , Mark Rutland , "grant.likely@linaro.org" , Will Deacon , Lorenzo Pieralisi , "graeme.gregory@linaro.org" , Sudeep Holla , "jcm@redhat.com" , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Daniel Lezcano , Mark Brown , Rob Herring , Robert Richter , Randy Dunlap , Charles Garcia-Tobin , "phoenix.liyi@huawei.com" , Timur Tabi , Ashwin Chaugule , "suravee.suthikulpanit@amd.com" , Mark Langsdorf , "wangyijing@huawei.com" , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , Liviu Dudau Subject: Re: [PATCH v8 06/21] ARM64 / ACPI: Introduce PCI stub functions for ACPI Date: Tue, 03 Feb 2015 15:55:05 +0100 Message-ID: <2157836.CgDKH4QWp1@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.16.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <54D0CD58.2000609@linaro.org> References: <1422881149-8177-1-git-send-email-hanjun.guo@linaro.org> <20150203121546.GD3677@e104818-lin.cambridge.arm.com> <54D0CD58.2000609@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1752 Lines: 53 On Tuesday, February 03, 2015 09:30:00 PM Hanjun Guo wrote: > On 2015年02月03日 20:15, Catalin Marinas wrote: > > On Mon, Feb 02, 2015 at 12:45:34PM +0000, Hanjun Guo wrote: > >> diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c > >> index ce5836c..c17e7ea 100644 > >> --- a/arch/arm64/kernel/pci.c > >> +++ b/arch/arm64/kernel/pci.c > >> @@ -10,6 +10,7 @@ > >> * > >> */ > >> > >> +#include > >> #include > >> #include > >> #include > >> @@ -68,3 +69,27 @@ void pci_bus_assign_domain_nr(struct pci_bus *bus, struct device *parent) > >> bus->domain_nr = domain; > >> } > >> #endif > >> + > >> +/* > >> + * raw_pci_read/write - Platform-specific PCI config space access. > >> + */ > >> +int raw_pci_read(unsigned int domain, unsigned int bus, > >> + unsigned int devfn, int reg, int len, u32 *val) > >> +{ > >> + return -EINVAL; > >> +} > >> + > >> +int raw_pci_write(unsigned int domain, unsigned int bus, > >> + unsigned int devfn, int reg, int len, u32 val) > >> +{ > >> + return -EINVAL; > >> +} > > > > You said you'll make these return -ENOSYS, which I think makes more > > sense. > > I'm sorry, I missed that, my bad, I will fix that in next version. Actually, -ENOSYS *specifically* means "not implemented system call". It should not be used for anything other than that. -ENXIO is what should be used instead. -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/