Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966004AbbBCPPn (ORCPT ); Tue, 3 Feb 2015 10:15:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58079 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965790AbbBCPPi convert rfc822-to-8bit (ORCPT ); Tue, 3 Feb 2015 10:15:38 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20150202193154.GC10842@pengutronix.de> References: <20150202193154.GC10842@pengutronix.de> <35FD53F367049845BC99AC72306C23D1044A02027E0A@CNBJMBX05.corpusers.net> To: Uwe =?us-ascii?Q?=3D=3Fiso-8859-1=3FQ=3FKleine-K=3DF6nig=3F=3D?= Cc: dhowells@redhat.com, "Wang\, Yalin" , "'arnd\@arndb.de'" , "'linux-arch\@vger.kernel.org'" , "'linux-kernel\@vger.kernel.org'" , "'linux\@arm.linux.org.uk'" , "'linux-arm-kernel\@lists.infradead.org'" Subject: Re: [RFC] change non-atomic bitops method MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Date: Tue, 03 Feb 2015 15:14:43 +0000 Message-ID: <30242.1422976483@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 475 Lines: 16 Uwe Kleine-König wrote: > Might be a matter of taste, but this check is equivalent to > > *p != (*p | mask) > > which is what you really want to test for. I would argue that this is less clear as to what's going on. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/