From: bill <bilel.dr@gmail.com>
Date: Tue, 3 Feb 2015 21:05:30 +0100
To: Joe Perches <joe@perches.com>
Cc: Bilel DRIRA <bilel.dr@gmail.com>, marek.belisko@gmail.com,
        gregkh@linuxfoundation.org, tapaswenipathak@gmail.com,
        gdonald@gmail.com, aybuke.147@gmail.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: [PATCH] staging: ft1000: fix braces warning
Message-ID: <20150203200530.GA15325@bill-Lenovo-IdeaPad-Z510>
References: <1422989883-16937-1-git-send-email-bilel.dr@gmail.com>
 <1422990308.30476.37.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1422990308.30476.37.camel@perches.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1158
Lines: 37

Ok,thank you, I will do that and resend the patch again.

On Tue, Feb 03, 2015 at 11:05:08AM -0800, Joe Perches wrote:
> On Tue, 2015-02-03 at 19:58 +0100, Bilel DRIRA wrote:
> > This patch fix the checkpatch.pl WARNING:
> []
> > diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
> []
> > @@ -1963,11 +1948,10 @@ static irqreturn_t ft1000_interrupt(int irq, void *dev_id)
> >  						ft1000_read_reg(dev,
> >  								FT1000_REG_MAG_DFSR);
> >  				}
> > -				if (tempword & 0x1f) {
> > +				if (tempword & 0x1f)
> >  					ft1000_copy_up_pkt(dev);
> > -				} else {
> > +				else
> >  					break;
> > -				}
> >  				cnt++;
> >  			} while (cnt < MAX_RCV_LOOP);
> >  
> 
> trivia: the logic here is generally better inverted:
> 
> 				if (!(tempword & 0x1f))
> 					break;
> 				ft1000_copy_up_pkt(dev);
> 				cnt++;
> 			} while (cnt < etc...)
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/