Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966663AbbBCUOc (ORCPT ); Tue, 3 Feb 2015 15:14:32 -0500 Received: from smtprelay0008.hostedemail.com ([216.40.44.8]:55941 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966604AbbBCUO2 (ORCPT ); Tue, 3 Feb 2015 15:14:28 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2110:2393:2553:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3622:3865:3868:3871:3872:3873:3874:4250:4321:5007:6261:10004:10400:10848:11232:11657:11658:11914:12043:12517:12519:12679:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: elbow28_43c6f5ec0672f X-Filterd-Recvd-Size: 1718 Message-ID: <1422994464.30476.45.camel@perches.com> Subject: Re: [PATCH] staging: ft1000: fix braces warning From: Joe Perches To: bill Cc: marek.belisko@gmail.com, gregkh@linuxfoundation.org, tapaswenipathak@gmail.com, gdonald@gmail.com, aybuke.147@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org Date: Tue, 03 Feb 2015 12:14:24 -0800 In-Reply-To: <20150203200530.GA15325@bill-Lenovo-IdeaPad-Z510> References: <1422989883-16937-1-git-send-email-bilel.dr@gmail.com> <1422990308.30476.37.camel@perches.com> <20150203200530.GA15325@bill-Lenovo-IdeaPad-Z510> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 909 Lines: 26 On Tue, 2015-02-03 at 21:05 +0100, bill wrote: > Ok,thank you, I will do that and resend the patch again. I wouldn't. It's probably better as a separate patch anyway. btw: please don't top post. cheers, Joe > On Tue, Feb 03, 2015 at 11:05:08AM -0800, Joe Perches wrote: > > On Tue, 2015-02-03 at 19:58 +0100, Bilel DRIRA wrote: > > > This patch fix the checkpatch.pl WARNING: > > [] > > > diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c > > [] > > > @@ -1963,11 +1948,10 @@ static irqreturn_t ft1000_interrupt(int irq, void *dev_id) [] > > trivia: the logic here is generally better inverted: -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/